Re: [patch 1/1] Add subsystem accessors

[Holger Eitzenberger <heitzenberger@astaro.com>]

Pablo Neira Ayuso wrote:

>> Need by newer ulogd v2.
> 
> Why do you need this? If I apply this, I'll have to provide support for
> people mixing calls to libnfnetlink and libnetfilter_conntrack which can
> be a problematic. The subsys handles are encapsulated for that reason.
> 
> If you really need them, I suggest you to use libnfnetlink together with
> the low level functions libnetfilter_conntrack functions:
> nfct_[build|parse]_conntrack and nfct_build_query.

Which would nullify the use of libnetfilter-conntrack with ulogd.

BTW, after using the new libnetfilter-conntrack I get this:

  ulogd_inpflow_NFCT.c:455: warning: passing argument 1 of 'nfnl_send'
   discards qualifiers from pointer target type
ulogd_inpflow_NFCT.c: In function 'read_cb_nfct':
  ulogd_inpflow_NFCT.c:1043: warning: passing argument 1 of 
'nfnl_recv_msgs' discards qualifiers from pointer target type
  ulogd_inpflow_NFCT.c: In function 'nfct_start':
ulogd_inpflow_NFCT.c:1156: warning: passing argument 1 of
  'nfnl_rcvbufsiz' discards qualifiers from pointer target type
ulogd_inpflow_NFCT.c: In function 'read_cb_nfct':
  ulogd_inpflow_NFCT.c:1043: warning: passing argument 1 of 
'nfnl_recv_msgs' discards qualifiers from pointer target type
...

Do you accept patches for that or should I just cast-away the wrong 
const there?

  /holger