From: Jeff Garzik <jeff@garzik.org>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: netdev@vger.kernel.org, David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH] macb: Fix section mismatch and shrink runtime footprint
Date: Fri, 01 Feb 2008 13:40:55 -0500 [thread overview]
Message-ID: <47A367B7.1030305@garzik.org> (raw)
In-Reply-To: <1201781422-30181-1-git-send-email-hskinnemoen@atmel.com>
Haavard Skinnemoen wrote:
> macb devices are only found integrated on SoCs, so they can't be
> hotplugged. Thus, the probe() and exit() functions can be __init and
> __exit, respectively. By using platform_driver_probe() instead of
> platform_driver_register(), there won't be any references to the
> discarded probe() function after the driver has loaded.
>
> This also fixes a section mismatch due to macb_probe(), defined as
> __devinit, calling macb_get_hwaddr, defined as __init.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> drivers/net/macb.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
applied
prev parent reply other threads:[~2008-02-01 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 12:10 [PATCH] macb: Fix section mismatch and shrink runtime footprint Haavard Skinnemoen
2008-02-01 18:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A367B7.1030305@garzik.org \
--to=jeff@garzik.org \
--cc=david-b@pacbell.net \
--cc=hskinnemoen@atmel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.