All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <ak@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] x86: setup code_bytes - use mask to restrict it's size
Date: Sat, 02 Feb 2008 14:25:09 -0800	[thread overview]
Message-ID: <47A4EDC5.3050104@zytor.com> (raw)
In-Reply-To: <20080202221211.GA6749@cvg>

Cyrill Gorcunov wrote:
> This patch strips off 8 bytes from text section. Not a really
> big advantage (especially for __init section). It seems 8192
> bytes of disassembled code is rare used anyway.
> 
> before:
> 	text    data     bss     dec     hex filename
> 	9900     176      20   10096    2770 arch/x86/kernel/traps_64.o.old
> after:
> 	text    data     bss     dec     hex filename
> 	9892     176      20   10088    2768 arch/x86/kernel/traps_64.o
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> 
> If there is no benefit at all - just drop the patch.
> Any comments are welcome ;)

I don't think this is the behaviour we want (wrapping around); worse, if 
people enter a larger power of two they will get zero.

So NAK on this patch, IMO.

	-hpa

  reply	other threads:[~2008-02-02 22:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-02 22:12 [RFC] x86: setup code_bytes - use mask to restrict it's size Cyrill Gorcunov
2008-02-02 22:25 ` H. Peter Anvin [this message]
2008-02-02 22:32   ` Cyrill Gorcunov
2008-02-02 22:59     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A4EDC5.3050104@zytor.com \
    --to=hpa@zytor.com \
    --cc=ak@suse.de \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.