All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL
Date: Sun, 03 Feb 2008 15:31:38 +0800	[thread overview]
Message-ID: <47A56DDA.9000907@cn.fujitsu.com> (raw)
In-Reply-To: <20080203071251.GB19020@elte.hu>

Ingo Molnar wrote:
> * Li Zefan <lizf@cn.fujitsu.com> wrote:
> 
>> +#ifdef CONFIG_SYSCTL
>>  static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu);
>> +#endif
> 
> instead of adding another #ifdef, a much cleaner solution would be to 
> just reorder do_nmi_callback() with unknown_nmi_panic_callback(), and 
> eliminate the prototype altogether.
> 
> 	Ingo
> 

I was wondering if a smaller patch will be better. But no doult cleaner
code is better. :)

  reply	other threads:[~2008-02-03  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03  6:18 [PATCH] x86: fix compile waring building without CONFIG_SYSCTL Li Zefan
2008-02-03  7:12 ` Ingo Molnar
2008-02-03  7:31   ` Li Zefan [this message]
2008-02-03  7:40     ` [PATCH] x86: fix compile warning " Li Zefan
2008-02-15 20:21       ` Ingo Molnar
2008-02-17 13:56       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A56DDA.9000907@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.