Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

[Franck Bui-Huu <vagabon.xyz@gmail.com>]

Andrew Morton wrote:
> On Sun, 03 Feb 2008 09:45:25 +0100 Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> 
>> Andrew Morton wrote:
>>> On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
>>>> Do you think it's better ?
>>> Could.  I'd suggest that you redo the header-file split patch around the
>>> 2.6.25-rc1 timeframe, test it carefully then let's get it in then.
>>>
>> Does the mm tree also have a calm down period during release candidates ?
> 
> Yes, I try to not merge too much material late in the -rcs and in the merge
> window.  Often it's not practical to merge things anyway, because people
> prepare patches against mainline, which is ancient history...
> 
>> I have modified the patchset so now if rcu helpers are used from
>> rculist.h then fine otherwise gcc warns you that you're using the
>> helpers from list.h like this:
>>
>> init/foo.c:13: warning: ‘__deprecated_list_add_rcu’ is deprecated (declared at include/linux/rculist.h:76)
>>
>> But the build process doesn't fail anymore.
>>
>> For that I added some ugly hacks in list.h and rculist.h but they
>> definitively should be removed for mainline inclusion. I'm sending them
>> in response to this email.
> 
> I wouldn't bother, really.  Let's just get it as good as we can and slam it
> in.
> 
>> If we include this now, then people can have a chance to notice that
>> rculist.h exists and fix their stuffs until 2.6.25 release
>> candidates but I'll redo the patchset and give it some test around the
>> 2.6.25-rc1 timeframe anyway.
> 
> I'm just about finished compilation-testing for 2.6.24-mm1 which is a
> shame.  Please do a best-effort against 2.6.24-mm1 (hopefully I'll get that
> out tomorrow) and I'll slip it into -rc1 if it gets through cross-build
> testing without unfixable-with-my-patience-level problems.
> 

OK.

I'm waiting for 2.6.24-mm1 and resend the patchset for 2.6.25-rc1 after
some good testings on mm tree.

Thanks
		Franck