From: "Roger C. Soares" <rogersoares@intelinet.com.br>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Comment private modifier to improve performace.
Date: Sun, 03 Feb 2008 18:03:35 -0200 [thread overview]
Message-ID: <47A61E17.7060303@intelinet.com.br> (raw)
In-Reply-To: <200802030326.40446.robin.rosenberg@dewire.com>
With the else warnings patch I'm ok.
About the discouraged access, I read those warnings as: we are using
methods that are not part of the eclipse public API and they can change
in the future. Not depending on internal eclipse API will make egit less
likely to break with a future eclipse version, which sounds like a good
thing to me. So, I would keep those.
[]s,
Roger.
--
Robin Rosenberg escreveu:
> We could drop these settings from the projects too.
>
> -- robin
>
> ------------------------------------------------------------------------
>
> From a1aed72a122a05d01ed57db5d51b45debeb247b7 Mon Sep 17 00:00:00 2001
> From: Robin Rosenberg <robin.rosenberg@dewire.com>
> Date: Sun, 3 Feb 2008 03:13:44 +0100
> Subject: [PATCH] Make it possible to ignore warnings about discouraged access
>
> By removing the setting from the project the workspace settings
> will be applied (default: Warning)
>
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> 5 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> index 7a0fbe4..1c978ca 100644
> --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning
> diff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> index bcde160..2afc050 100644
> --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning
> diff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> index 0a89f52..0da92c7 100644
> --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning
> diff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> index c203c20..9adf651 100644
> --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning
> diff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> index b0c694c..faecf76 100644
> --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> @@ -14,7 +14,6 @@ org.eclipse.jdt.core.compiler.problem.autoboxing=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
> -org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning
>
> ------------------------------------------------------------------------
>
> From e9f312599eb5941a7bf1acd70c6f0ac9fb1ea889 Mon Sep 17 00:00:00 2001
> From: Robin Rosenberg <robin.rosenberg@dewire.com>
> Date: Sun, 3 Feb 2008 03:19:09 +0100
> Subject: [PATCH] Drop warnings about unnecessary else
>
> Use workspace setting, default ignore.
>
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 1 -
> .../.settings/org.eclipse.jdt.core.prefs | 3 +--
> 5 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> index 1c978ca..7279d81 100644
> --- a/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.core.test/.settings/org.eclipse.jdt.core.prefs
> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
> org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
> org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
> org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
> org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
> org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
> org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
> diff --git a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> index 2afc050..2d94530 100644
> --- a/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.core/.settings/org.eclipse.jdt.core.prefs
> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
> org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
> org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
> org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
> org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
> org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
> org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
> diff --git a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> index 0da92c7..ff09222 100644
> --- a/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.egit.ui/.settings/org.eclipse.jdt.core.prefs
> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
> org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
> org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
> org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
> org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
> org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
> org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
> diff --git a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> index 9adf651..b93093f 100644
> --- a/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.jgit.test/.settings/org.eclipse.jdt.core.prefs
> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
> org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
> org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
> org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
> org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
> org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
> org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
> diff --git a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> index faecf76..4a5d15f 100644
> --- a/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> +++ b/org.spearce.jgit/.settings/org.eclipse.jdt.core.prefs
> @@ -1,4 +1,4 @@
> -#Tue Dec 18 01:35:52 CET 2007
> +#Sun Feb 03 03:16:45 CET 2008
> eclipse.preferences.version=1
> org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
> org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
> @@ -58,7 +58,6 @@ org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
> org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
> org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=warning
> org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
> -org.eclipse.jdt.core.compiler.problem.unnecessaryElse=warning
> org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=error
> org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
> org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=error
>
next prev parent reply other threads:[~2008-02-03 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 2:23 [EGIT PATCH] Comment private modifier to improve performace Roger C. Soares
2008-02-03 1:01 ` Robin Rosenberg
2008-02-03 2:26 ` Robin Rosenberg
2008-02-03 20:03 ` Roger C. Soares [this message]
2008-02-03 22:14 ` Robin Rosenberg
2008-02-03 19:46 ` Roger C. Soares
2008-02-03 22:25 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A61E17.7060303@intelinet.com.br \
--to=rogersoares@intelinet.com.br \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.