From: Tejun Heo <htejun@gmail.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: AHCI driver preferring nr_ports over port map
Date: Mon, 04 Feb 2008 22:16:44 +0900 [thread overview]
Message-ID: <47A7103C.1040804@gmail.com> (raw)
In-Reply-To: <47A70EA90200007800045D32@public.id2-vpn.continvity.gns.novell.com>
Jan Beulich wrote:
>> Do you have any real case where the above behavior causes problem?
>
> It's not strictly a problem (i.e. nothing really mis-behaves), but it made
> me wonder why the box I saw this on gets 6 ahci device instances set
> up when spec as well as port map say there ought to be only 5. After
> looking at the ESB2 spec it seemed that behavior was clearly violating
> the spec: "For ports that are not available, software must not read or
> write to registers within that port.", which contradicts status being
> displayed for (and therefore status being read) from the 6th (not
> present) port.
Well, two values don't agree with each other and we know for a fact that
vendors sometimes get PI wrong, so we trust n_ports in such cases. We
can reverse the behavior but that's likely to cause more problems than
it fixes.
--
tejun
next prev parent reply other threads:[~2008-02-04 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 13:10 AHCI driver preferring nr_ports over port map Jan Beulich
2008-02-04 13:16 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-04 13:24 Jan Beulich
2008-02-04 13:38 ` Tejun Heo
2008-02-05 7:47 ` Jan Beulich
2008-02-05 12:21 ` Tejun Heo
2008-02-05 12:40 ` Jan Beulich
2008-02-05 13:17 ` Tejun Heo
2008-02-05 14:51 ` Jan Beulich
2008-02-01 15:12 Jan Beulich
2008-02-02 8:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A7103C.1040804@gmail.com \
--to=htejun@gmail.com \
--cc=jbeulich@novell.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.