From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JM2bI-0003fv-0Q for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 09:47:12 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JM2bG-0003e9-5S for grub-devel@gnu.org; Mon, 04 Feb 2008 09:47:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JM2bE-0003cX-62 for grub-devel@gnu.org; Mon, 04 Feb 2008 09:47:09 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JM2bE-0003cO-2z for grub-devel@gnu.org; Mon, 04 Feb 2008 09:47:08 -0500 Received: from mx1.rz.ruhr-uni-bochum.de ([134.147.32.86]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JM2bD-0000mo-TU for grub-devel@gnu.org; Mon, 04 Feb 2008 09:47:08 -0500 X-Queued: (qmail 7328 invoked by uid 281); 4 Feb 2008 14:47:06 -0000 X-Qmailscanner: from 134.147.252.214 by mx1.rz.ruhr-uni-bochum.de (envelope-from , uid 80) with qmail-scanner-2.01 (sophie: 3.05/2.52/4.24. Clear:RC:1(134.147.252.214):. Processed in 0.068611 secs); 04 Feb 2008 14:47:06 -0000 Received: from router.leat.ruhr-uni-bochum.de (134.147.252.214) by mx1.rz.ruhr-uni-bochum.de with SMTP; 4 Feb 2008 14:47:05 -0000 Received: from [134.147.55.45] (frodo.leat.ruhr-uni-bochum.de [134.147.55.45]) by router.leat.ruhr-uni-bochum.de (8.12.2/8.12.2/SuSE Linux 0.6) with ESMTP id m14Epm1l021086; Mon, 4 Feb 2008 15:51:48 +0100 Message-ID: <47A7257E.1090807@leat.rub.de> Date: Mon, 04 Feb 2008 15:47:26 +0100 From: Fabian Greffrath User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Robert Millan References: <47948422.8000208@leat.rub.de> <20080121121828.GA9244@thorin> <4795B435.20102@leat.rub.de> <20080122124642.GC2017@thorin> <4795EC4D.5020207@leat.rub.de> <47A05477.5030300@leat.rub.de> <20080130194854.GA2143@thorin> <47A1877D.7020009@leat.rub.de> <20080131115855.GA13960@thorin> <47A6D04E.4070106@leat.rub.de> <20080204141837.GB7432@thorin> In-Reply-To: <20080204141837.GB7432@thorin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 Cc: The development of GRUB 2 , 462218@bugs.debian.org, Otavio Salvador Subject: Re: Bug#461442: detection of other OSes in update-grub X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 14:47:10 -0000 Robert Millan schrieb: > Why is that a problem? > Because foobar is not a block device, but grub-probe claims that it will print a device if '--target=device' is given. > I think this function could be called from the other part of this file which > performs similar checks (if this functionality is to be kept, that is). > Yes, I am fine with this. > I know that the call to probe() is not supposed to be reentrant, but I'd > prefer not to break reentrancy if it can be easily avoided; it is possible > that probe() needs to recurse onto itself in the future (because of RAID/LVM). > OK, but should I keep it uninitialized? > Please remember to fix that in later versions of the patch ;-) > Sure, my copyright assignment paper is on it's way... > Is it possible to share code with 10_linux.in here? > Only if os-prober is installed. But then, os-prober does not check for kernels on / and /target. > Maybe this can be simplified with "echo something | read a b c d" feature? > For cosmetic reasons, yes. ;) Cheers, Fabian -- Dipl.-Phys. Fabian Greffrath Ruhr-Universität Bochum Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT) Universitätsstr. 150, IB 3/134 D-44780 Bochum Telefon: +49 (0)234 / 32-26334 Fax: +49 (0)234 / 32-14227 E-Mail: greffrath@leat.ruhr-uni-bochum.de