From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Cyrill Gorcunov <gorcunov@gmail.com>, Andi Kleen <ak@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: vmlinux_64.lds.S - use THREAD_SIZE instead of numeric constant
Date: Mon, 04 Feb 2008 12:39:25 -0800 [thread overview]
Message-ID: <47A777FD.7080208@zytor.com> (raw)
In-Reply-To: <20080204203315.GA31341@elte.hu>
Ingo Molnar wrote:
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
>> Hi Cyrill.
>> On Mon, Feb 04, 2008 at 08:10:37PM +0300, Cyrill Gorcunov wrote:
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>> The patch looks simple but please explain why you do what you do. It
>> took me some digging before I could convince mysleft this was indeed a
>> correct change. And I am pretty sure you did the same investigation
>> yourself.
>>
>> A comment like:
>>
>> arch/x866/kernel/inittask.c require all variables allocated in
>> the section .data.init_task to be aligned with THREAD_SIZE.
>>
>> would have made me happy.
>
> Btw., given that on x86 we've moved away from the %esp based task stack
> trick and use an %fs based Percpu-Data-Area (PDA) to access the current
> task pointer, this alignment might not be necessary anymore. It's a
> historic relic of the mask-%esp trick.
>
Was that *ever* used on x86-64? I thought x86-64 always used %gs for this.
-hpa
next prev parent reply other threads:[~2008-02-04 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 17:10 [PATCH] x86: vmlinux_64.lds.S - use THREAD_SIZE instead of numeric constant Cyrill Gorcunov
2008-02-04 20:22 ` Sam Ravnborg
2008-02-04 20:33 ` Ingo Molnar
2008-02-04 20:39 ` H. Peter Anvin [this message]
2008-02-04 21:12 ` Cyrill Gorcunov
2008-02-04 21:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A777FD.7080208@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.