From: Roel Kluin <12o3l@tiscali.nl>
To: garloff@suse.de, g.liakhovetski@gmx.de,
lkml <linux-kernel@vger.kernel.org>
Subject: [drivers/scsi/NCR53C9x.c] remove duplication for family_code == 0x00
Date: Mon, 04 Feb 2008 23:22:26 +0100 [thread overview]
Message-ID: <47A79022.4010302@tiscali.nl> (raw)
in drivers/scsi/NCR53C9x.c:412-422 it reads:
else if(family_code == 0x00) {
if ((version & 7) == 2)
esp->erev = fas100a; /* NCR53C9X */
else
esp->erev = espunknown;
} else if(family_code == 0x14) {
if ((version & 7) == 2)
esp->erev = fsc;
else
esp->erev = espunknown;
} else if(family_code == 0x00) {
if ((version & 7) == 2)
esp->erev = fas100a; /* NCR53C9X */
else
esp->erev = espunknown;
Note the duplication of test 'if(family_code == 0x00)' and lines below
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 5b0efc9..b8df3c0 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -419,11 +419,6 @@ static void esp_reset_esp(struct NCR_ESP *esp, struct ESP_regs *eregs)
esp->erev = fsc;
else
esp->erev = espunknown;
- } else if(family_code == 0x00) {
- if ((version & 7) == 2)
- esp->erev = fas100a; /* NCR53C9X */
- else
- esp->erev = espunknown;
} else
esp->erev = espunknown;
ESPLOG(("esp%d: FAST chip is %s (family=%d, version=%d)\n",
reply other threads:[~2008-02-04 22:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A79022.4010302@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=g.liakhovetski@gmx.de \
--cc=garloff@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.