All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Larson <clarson@kergoth.com>
To: git@vger.kernel.org
Subject: [PATCH] Fix bug in parse_color that prevented the user from changing the background colors.
Date: Tue, 05 Feb 2008 10:34:34 -0700	[thread overview]
Message-ID: <47A89E2A.9010905@kergoth.com> (raw)

The comments in color.c indicate that the syntax for the color options 
in the
git config is [fg [bg]] [attr], however the implementation fails if 
strtol is
unable to convert the string in its entirety into an integer.

Signed-off-by: Chris Larson <clarson@kergoth.com>
---
 color.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/color.c b/color.c
index 7f66c29..62518fa 100644
--- a/color.c
+++ b/color.c
@@ -17,7 +17,7 @@ static int parse_color(const char *name, int len)
             return i - 1;
     }
     i = strtol(name, &end, 10);
-    if (*name && !*end && i >= -1 && i <= 255)
+    if (*name && i >= -1 && i <= 255)
         return i;
     return -2;
 }
-- 
1.5.4.29.g43ce-dirty

             reply	other threads:[~2008-02-05 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 17:34 Chris Larson [this message]
2008-02-05 18:39 ` [PATCH] Fix bug in parse_color that prevented the user from changing the background colors Timo Hirvonen
     [not found]   ` <b6ebd0a50802051045t4949df68u7e405ea618403a31@mail.gmail.com>
2008-02-05 18:48     ` Chris Larson
2008-02-05 18:58     ` Timo Hirvonen
2008-02-05 19:18       ` [PATCH] Fix parsing numeric color values Timo Hirvonen
2008-02-06  9:59         ` Junio C Hamano
2008-02-06 12:16           ` [PATCH v2] " Timo Hirvonen
2008-02-06 12:16           ` [PATCH] Add tests for diff/status color parser Timo Hirvonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A89E2A.9010905@kergoth.com \
    --to=clarson@kergoth.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.