From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
michael.pyne@kdemail.net, AAbdulla@nvidia.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)
Date: Tue, 05 Feb 2008 10:38:56 -0800 [thread overview]
Message-ID: <47A8AD40.7010007@zytor.com> (raw)
In-Reply-To: <47A8A90B.6010602@garzik.org>
Jeff Garzik wrote:
>>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> NAK - this fixes one set of users, and breaks a working set of users.
>
> Need to add DMI check for the specific motherboard (dmi_check_system),
> and flip flag according to success/failure of that check.
>
Either that, or detect the Gigabyte prefix used as a suffix, since they
seem to be the source of this particular f*ckup.
-hpa
next prev parent reply other threads:[~2008-02-05 18:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 7:47 [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23) akpm
2008-02-05 18:20 ` Jeff Garzik
2008-02-05 18:38 ` H. Peter Anvin [this message]
2008-02-05 18:42 ` Jeff Garzik
2008-02-05 20:11 ` H. Peter Anvin
2008-02-05 18:59 ` Andrew Morton
2008-02-04 17:33 ` Ayaz Abdulla
2008-02-05 19:13 ` Jeff Garzik
2008-02-04 17:57 ` Ayaz Abdulla
2008-02-06 2:06 ` Michael Pyne
2008-02-06 2:06 ` Michael Pyne
2008-02-05 19:08 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A8AD40.7010007@zytor.com \
--to=hpa@zytor.com \
--cc=AAbdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.pyne@kdemail.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.