All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	ide <linux-ide@vger.kernel.org>, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] sata_nv: fix ATAPI issues with memory over 4GB (v7)
Date: Wed, 06 Feb 2008 07:04:14 -0500	[thread overview]
Message-ID: <47A9A23E.5060006@garzik.org> (raw)
In-Reply-To: <47A7BE36.1010902@shaw.ca>

Robert Hancock wrote:
> This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
> on systems with memory located above 4GB. We need to delay setting the 64-bit
> DMA mask until the PRD table and padding buffer are allocated so that they don't
> get allocated above 4GB and break legacy mode (which is needed for ATAPI
> devices). Also, if either port is in ATAPI mode we need to set the DMA mask
> for the PCI device to 32-bit to ensure that the IOMMU code properly bounces
> requests above 4GB, as it appears setting the bounce limit does not guarantee
> that we will not try to map requests above this point.
> 
> Reported to fix https://bugzilla.redhat.com/show_bug.cgi?id=351451
> 
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>

applied, though it can still be improved...  let's see if this sticks.



      reply	other threads:[~2008-02-06 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05  1:39 [PATCH] sata_nv: fix ATAPI issues with memory over 4GB (v7) Robert Hancock
2008-02-06 12:04 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A9A23E.5060006@garzik.org \
    --to=jeff@garzik.org \
    --cc=hancockr@shaw.ca \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.