From: matthieu castet <castet.matthieu@free.fr>
To: linux-acpi@vger.kernel.org
Subject: [PATCH] check that acpi_wakeup_address is below 1MB
Date: Wed, 06 Feb 2008 23:47:11 +0100 [thread overview]
Message-ID: <47AA38EF.6030307@free.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
Hi,
this patch had a check that the memory allocated is in the first 1MB.
The check is similar to the one in smp_alloc_memory.
Signed-off-by: "Matthieu CASTET <castet.matthieu@free.fr>"
[-- Attachment #2: acpi.diff --]
[-- Type: text/x-patch, Size: 522 bytes --]
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index 6bc815c..65ab23c 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -65,6 +65,10 @@ void __init acpi_reserve_bootmem(void)
acpi_wakeup_address = (unsigned long)alloc_bootmem_low(PAGE_SIZE*2);
if (!acpi_wakeup_address)
printk(KERN_ERR "ACPI: Cannot allocate lowmem, S3 disabled.\n");
+
+ /* check if we are in first 1MB of memory */
+ if (__pa(acpi_wakeup_address) >= 1024*1024-PAGE_SIZE*2)
+ BUG();
}
next reply other threads:[~2008-02-06 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 22:47 matthieu castet [this message]
2008-02-06 22:56 ` [PATCH] check that acpi_wakeup_address is below 1MB Ingo Molnar
2008-02-06 23:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AA38EF.6030307@free.fr \
--to=castet.matthieu@free.fr \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.