All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	kgdb-bugreport@lists.sourceforge.net
Subject: [PATCH] KGDB-8250: fix initial interrupt
Date: Thu, 07 Feb 2008 08:38:36 +0100	[thread overview]
Message-ID: <47AAB57C.7090501@web.de> (raw)

Latest rework of kgdb8250_interrupt caused a regression in that the new
code wrongly assumes a ctrl-c character is also sent on initial connect
from the host. Here is a fix.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>

---
 drivers/serial/8250_kgdb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/drivers/serial/8250_kgdb.c
===================================================================
--- a/drivers/serial/8250_kgdb.c
+++ b/drivers/serial/8250_kgdb.c
@@ -124,10 +124,10 @@ static irqreturn_t kgdb8250_interrupt(in

 	if ((iir & UART_IIR_ID) == UART_IIR_RDI) {
 		c = kgdb8250_ioread(UART_RX);
-		if (c == 0x03)
-			breakpoint();
-		else
+		if (c != 0x03)
 			buffered_char = c;
+		if (c == 0x03 || !kgdb_connected)
+			breakpoint();
 	}
 	return IRQ_HANDLED;
 }

                 reply	other threads:[~2008-02-07  7:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AAB57C.7090501@web.de \
    --to=jan.kiszka@web.de \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.