From: Jan Kiszka <jan.kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: adeos-main <adeos-main@gna.org>
Subject: [Adeos-main] [PATCH] Sort stack dumps on non-root faults
Date: Thu, 07 Feb 2008 14:02:10 +0100 [thread overview]
Message-ID: <47AB0152.20205@domain.hid> (raw)
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
Hi Philippe,
while trying to understand Petr's problem (no clue yet), I came across
this: dump_stack was called unconditionally, ipipe_trace_panic_dump was
missing.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
[-- Attachment #2: sort-stack-dumping-on-nonroot-faults.patch --]
[-- Type: text/x-patch, Size: 1214 bytes --]
---
arch/x86/kernel/ipipe.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
Index: b/arch/x86/kernel/ipipe.c
===================================================================
--- a/arch/x86/kernel/ipipe.c
+++ b/arch/x86/kernel/ipipe.c
@@ -770,19 +770,22 @@ int __ipipe_handle_exception(struct pt_r
ipipe_trace_panic_freeze();
/* Always warn about user land and unfixable faults. */
- if ((error_code & 4) || !search_exception_tables(instruction_pointer(regs)))
+ if ((error_code & 4) || !search_exception_tables(instruction_pointer(regs))) {
printk(KERN_ERR "BUG: Unhandled exception over domain"
" %s at 0x%lx - switching to ROOT\n",
ipd->name, instruction_pointer(regs));
+ dump_stack();
+ ipipe_trace_panic_dump();
#ifdef CONFIG_IPIPE_DEBUG
/* Also report fixable ones when debugging is enabled. */
- else
+ } else {
printk(KERN_WARNING "WARNING: Fixable exception over "
"domain %s at 0x%lx - switching to ROOT\n",
ipd->name, instruction_pointer(regs));
+ dump_stack();
+ ipipe_trace_panic_dump();
#endif /* CONFIG_IPIPE_DEBUG */
-
- dump_stack();
+ }
}
__ipipe_std_extable[vector](regs, error_code);
reply other threads:[~2008-02-07 13:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AB0152.20205@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=adeos-main@gna.org \
--cc=rpm@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.