All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	e1000-devel@lists.sourceforge.net, jesse.brandeburg@intel.com,
	kernel list <linux-kernel@vger.kernel.org>,
	john.ronciak@intel.com, jeffrey.t.kirsher@intel.com
Subject: Re: [E1000-devel] e1000 1sec latency problem
Date: Thu, 07 Feb 2008 10:40:27 -0800	[thread overview]
Message-ID: <47AB509B.4030401@intel.com> (raw)
In-Reply-To: <47AB4E30.3060409@qualcomm.com>

Max Krasnyansky wrote:
> 
> Kok, Auke wrote:
>> Max Krasnyansky wrote:
>>> Kok, Auke wrote:
>>>> Max Krasnyansky wrote:
>>>>> So you don't think it's related to the interrupt coalescing by any chance ?
>>>>> I'd suggest to try and disable the coalescing and see if it makes any difference.
>>>>> We've had lots of issues with coalescing misbehavior. Not this bad (ie 1 second) though.
>>>>>
>>>>> Add this to modprobe.conf and reload e1000 module
>>>>>
>>>>> options e1000 RxIntDelay=0,0 RxAbsIntDelay=0,0 InterruptThrottleRate=0,0 TxIntDelay=0,0 TxAbsIntDelay=0,0
>>>> that can't be the problem. irq moderation would only account for 2-3ms variance
>>>> maximum.
>>> Oh, I've definitely seen worse than that. Not as bad as a 1second though. Plus you're talking
>>> about the case when coalescing logic is working as designed ;-). What if there is some kind of 
>>> bug where timer did not expire or something.
>> we don't use a software timer in e1000 irq coalescing/moderation, it's all in
>> hardware, so we don't have that problem at all. And I certainly have never seen
>> anything you are referring to with e1000 hardware, and I do not know of any bug
>> related to this.
>>
>> are you maybe confused with other hardware ?
>>
>> feel free to demonstrate an example...
> 
> Just to give you a background. I wrote and maintain http://libe1000.sf.net
> So I know E1000 HW and SW in and out.

wow, even I do not dare to say that!

> And no I'm not confused with other HW and I know that we're
> not using SW timers for the coalescing. HW can be buggy as well. Note that I'm not saying that I
> know for sure that the problem is coalescing, I'm just suggesting to take it out of the equation
> while Pavel is investigating.
> 
> Unfortunately I cannot demonstrate an example but I've seen unexplained packet delays in the range 
> of 1-20 milliseconds on E1000 HW (and boy ... I do have a lot of it in my labs). Once coalescing 
> was disabled those problems have gone away.

this sounds like you have some sort of PCI POST-ing problem and those can indeed
be worse if you use any form of interrupt coalescing. In any case that is largely
irrelevant to the in-kernel drivers, and as I said we definately have no open
issues on that right now, and I really do not recollect any as well either (other
than the issue of interference when both ends are irq coalescing)

Cheers,

Auke

  reply	other threads:[~2008-02-07 18:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 14:17 e1000 1sec latency problem Pavel Machek
2008-02-07 16:58 ` Max Krasnyansky
2008-02-07 17:25   ` [E1000-devel] " Kok, Auke
2008-02-07 18:06     ` Max Krasnyansky
2008-02-07 18:12       ` Kok, Auke
2008-02-07 18:30         ` Max Krasnyansky
2008-02-07 18:40           ` Kok, Auke [this message]
2008-02-07 18:55             ` Max Krasnyansky
2008-02-07 18:17 ` Kok, Auke
2008-02-07 22:24   ` Pavel Machek
2008-02-07 22:32     ` Kok, Auke
2008-02-07 22:37       ` Pavel Machek
2008-02-07 23:12         ` Kok, Auke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AB509B.4030401@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.