All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading
Date: Thu, 07 Feb 2008 16:35:39 -0600	[thread overview]
Message-ID: <47AB87BB.5080200@freescale.com> (raw)
In-Reply-To: <20080207162910.9d78d106.kim.phillips@freescale.com>

Kim Phillips wrote:

> I'd prefer firmware uploading bits remain apps (perhaps in examples/?)
> but I don't know the "U-Boot Philosophy" for this area..

The whole point behind this patch is to get rid of the currently application and 
make this a native feature of U-Boot.

In this regard, it is no different than my QE firmware patch.

> drivers/net bits go through net maintainer, Ben Warren (separate patch).

I can break it into two patches.

>> +#include <config.h>
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <asm/errno.h>
> 
> This breaks some archs.

Which ones?  How?  These header files look pretty harmless to me.  What if I did 
this:

#include <config.h>

#ifdef CONFIG_VSC7385_ENET

#include <common.h>
#include <asm/io.h>
#include <asm/errno.h>

> who is the original author of this code?

One of our BSP developers.  I took the code from his application and cleaned it up.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2008-02-07 22:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 19:19 [U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading Timur Tabi
2008-02-07 22:29 ` Kim Phillips
2008-02-07 22:35   ` Timur Tabi [this message]
2008-02-07 22:54   ` Wolfgang Denk
2008-02-08 15:31 ` Ben Warren
2008-02-08 16:44   ` Timur Tabi
2008-02-08 19:09     ` Scott Wood
2008-02-09  0:03     ` Ben Warren
2008-02-11 15:43       ` Timur Tabi
2008-02-11 15:46         ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AB87BB.5080200@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.