From: Scott Wood <scottwood@freescale.com>
To: Scott Wood <scottwood@freescale.com>,
jdl@jdl.com, linuxppc-dev@ozlabs.org
Subject: Re: [libfdt] RFC: Node iterators (v2)
Date: Thu, 07 Feb 2008 17:34:05 -0600 [thread overview]
Message-ID: <47AB956D.4090805@freescale.com> (raw)
In-Reply-To: <20080117051009.GA12239@localhost.localdomain>
David Gibson wrote:
> And here's a revised version. This now also handles recursive
> iteration and iteration across nodes without respect to depth. I've
> removed the for_each() macros for the time being, because they were
> making my brain hurt, but I'm still contemplating bringing them back.
> Several libfdt functions are now implemented using the new iterator,
> so this ends up as a code-size-reducing patch.
>
> I'm pretty happy with the basic outline of this now, although the
> names and details might want a bit of polish still.
Can we get this merged?
> +int _fdt_next_node(const void *fdt, int offset, int *depth)
> +{
This is a public function; why the underscore?
-Scott
next prev parent reply other threads:[~2008-02-07 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 6:20 [libfdt] RFC: Node iterators David Gibson
2008-01-17 5:10 ` [libfdt] RFC: Node iterators (v2) David Gibson
2008-02-07 23:34 ` Scott Wood [this message]
2008-02-11 3:13 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AB956D.4090805@freescale.com \
--to=scottwood@freescale.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.