From: Eric Sandeen <sandeen@redhat.com>
To: cmm@us.ibm.com
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space
Date: Thu, 07 Feb 2008 19:06:49 -0600 [thread overview]
Message-ID: <47ABAB29.2060300@redhat.com> (raw)
In-Reply-To: <1202429513.3840.12.camel@localhost.localdomain>
Mingming Cao wrote:
> Do you intend to remove the #ifdef CONFIG_PROC_FS, or it's a accident? I
> think we need keep that to allow ext4 build without procfs configured.
>
> Other than this, the patch looks fine to me.:)
oh, it kind of snuck in. It actually should still build, as
remove_proc_entry is a no-op function w/o the config option.
Feel free to leave it in if you like though.
-Eric
next prev parent reply other threads:[~2008-02-08 1:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 17:05 [PATCH] allocate struct ext4_allocation_context from a kmem cache to save stack space Eric Sandeen
2008-02-08 0:11 ` Mingming Cao
2008-02-08 1:06 ` Eric Sandeen [this message]
2008-02-08 1:37 ` Mingming Cao
2008-02-08 2:35 ` Eric Sandeen
2008-02-08 15:45 ` Dave Kleikamp
2008-02-08 16:39 ` Mingming Cao
2008-02-08 16:55 ` Eric Sandeen
2008-02-08 18:25 ` Mingming Cao
2008-02-08 18:43 ` Dave Kleikamp
2008-02-08 17:00 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ABAB29.2060300@redhat.com \
--to=sandeen@redhat.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.