From: Daniel J Walsh <dwalsh@redhat.com>
To: "Václav Ovsík" <vaclav.ovsik@i.cz>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
selinux@tycho.nsa.gov, Marshall Miller <mmiller@tresys.com>,
"Todd C. Miller" <tmiller@tresys.com>
Subject: Re: fixfiles: broken option processing?
Date: Fri, 08 Feb 2008 08:24:03 -0500 [thread overview]
Message-ID: <47AC57F3.4010509@redhat.com> (raw)
In-Reply-To: <20080208082922.GA26640@bobek.pm.i.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Václav Ovsík wrote:
> On Thu, Feb 07, 2008 at 04:28:03PM -0500, Stephen Smalley wrote:
>> Hmm..the shifting of arguments was introduced in r2699 from Dan Walsh
>> (cc'd), diff is below. Also relevant are r2736, r2750 and r2760.
>>
>> I'd agree that we don't want to break existing usage, but I'm not sure
>> what the least intrusive and cleanest fix is.
>
> Ok. What about this patch :)
>
> The interpreter is changed to /bin/bash. There are bashisms (getopts,
> PIPESTATUS...), so this can't be interpreted by /bin/sh.
>
> Regards
>
This looks good to me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iEYEARECAAYFAkesV/IACgkQrlYvE4MpobMndQCfRC9x2SUT/wwZmIAX2JlubED/
3LAAniOtNSEEldpmXGX/2vubL27yvezh
=1tZw
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-02-08 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 15:49 fixfiles: broken option processing? Václav Ovsík
2008-02-07 21:28 ` Stephen Smalley
2008-02-08 8:29 ` Václav Ovsík
2008-02-08 9:01 ` Václav Ovsík
2008-02-08 13:24 ` Daniel J Walsh [this message]
2008-02-08 16:19 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AC57F3.4010509@redhat.com \
--to=dwalsh@redhat.com \
--cc=mmiller@tresys.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=tmiller@tresys.com \
--cc=vaclav.ovsik@i.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.