From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: ipv6_chk_acast_addr remove unused loop Date: Fri, 08 Feb 2008 18:48:04 +0100 Message-ID: <47AC95D4.4090506@fr.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Netdev List , netdev-owner@vger.kernel.org, =?UTF-8?B?WU9TSElGVUpJIEhpZGVha2kgLyDlkInol6Q=?= =?UTF-8?B?6Iux5piO?= To: David Stevens Return-path: Received: from mtagate6.uk.ibm.com ([195.212.29.139]:44449 "EHLO mtagate6.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754849AbYBHRyM (ORCPT ); Fri, 8 Feb 2008 12:54:12 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: David Stevens wrote: > NACK. > > Daniel, > This code is part of the in-kernel API for anycast, which is > intended > to be the same as for multicast. By removing support for NULL there, > you're > making a special case for the anycast code that isn't there in the > multicast > code (can't support a NULL dev), and you really aren't buying all that > much for it. I was hesitating to send this patch exactly for the reason you are explaining. Apparently I did the bad choice :) Thanks. -- Daniel