Re: [Xenomai-core] [PATCH 0/5] Support for select v2.

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

Gilles Chanteperdrix wrote:
> Jan Kiszka wrote:
>  > Gilles Chanteperdrix wrote:
>  > > Hi,
>  > > 
>  > > after some tests, bug fixes and optimizations, here comes a second version of 
>  > > the patch-set adding select support to xenomai posix skin.
>  > > 
>  > 
>  > Puh, a lot of code, and my brain is still full of KGDB stuff I'm trying
>  > to polish for mainline since days.
>  > 
>  > The approach looks consistent to me. I would just suggest to make the
>  > whole thing configurable, so that it doesn't add overhead to systems
>  > which do not use it.
> 
> I am getting back to this select stuff. So I have a question, would you
> agree if the select support was made configurable, but if when this
> support was enabled, support for select was added to vanilla
> rtdm_event_t and rtdm_sem_t ? This would ease maintenance, since it
> would avoid a lot of code duplication, without adding to much overhead
> in my opinion (an empty list test when signaling the objects).

Looking at the code again, this really makes sense, go for it.

> 
>  > 
>  > Out of curiosity: Did you already have a chance to compare a
>  > multi-threaded demo application with one based on these new select services?
>  > 
>  > I guess your current test cases are built on top of RTnet, aren't they?
>  > Would be nice, also for regression testing, to have some demo for
>  > /examples, e.g. exploiting the CAN stack (because it has virtual CAN,
>  > thus it is usable without hardware).
> 
> Ok, I had a look at the CAN stack, if I understand correctly when
> receiving, the recv_sem defined in rcan_socket.h is used, and when
> sending, the tx_sem defined in rtcan_dev.h is used. Can you confirm this
> ? 

Yep, that's correct. rx_sem counts received packets, tx_sem the number
of available output slots in the CAN port.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]