Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

[Jason Wessel <jason.wessel@windriver.com>]

Jan Kiszka wrote:
> jason.wessel@windriver.com wrote:
>   
>> @@ -2175,9 +2187,9 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
>>  
>>  		/*
>>  		 * Power down all ports by default, except the
>> -		 * console if we have one.
>> +		 * console (real or kgdb) if we have one.
>>  		 */
>> -		if (!uart_console(port))
>> +		if (!uart_console(port) && !uart_kgdb(port))
>>  			uart_change_pm(state, 3);
>>     
>
> Jason, thinking about this hunk again, it appears broken to me. If we
> needed it for 8250_kgdb, we would also need it without
> CONFIG_KGDB_CONSOLE. However, powering on the UART with a special dance
> after we took over with 8250_kgdb is a job that has to be done _there_,
> not by this hook here. So let's drop the whole serial_core.c hunk from
> this patch.
>
> Jan
>   
Chunk dropped and the patches are refreshed in the git archive.

Jason.