[patch] more descriptive unknown glyph picture

[patch] more descriptive unknown glyph picture

[Vesa Jääskeläinen]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Hi All,

Here is a patch that changes this gray pattern for unknown glyphs to 
rounded question mark. This way user knows that something is missing :) 
(and it is easily visible).

Another story is, should we provide default fonts and/or use system 
fonts where available.

Thanks,
Vesa Jääskeläinen

[-- Attachment #2: unknown_glyph.diff --]
[-- Type: text/plain, Size: 1828 bytes --]

Index: ChangeLog
===================================================================
RCS file: /sources/grub/grub2/ChangeLog,v
retrieving revision 1.580
diff -u -p -r1.580 ChangeLog
--- ChangeLog	9 Feb 2008 12:31:10 -0000	1.580
+++ ChangeLog	9 Feb 2008 21:22:43 -0000
@@ -1,3 +1,9 @@
+2008-02-09  Vesa Jaaskelainen  <chaac@nic.fi>
+
+	* font/manager.c (unknown_glyph): Added variable for unknown glyph.
+	(fill_with_default_glyph): Changed to use unknown_glyph for fill
+	pattern for unknown glyphs.
+
 2008-02-09  Robert Millan  <rmh@aybabtu.com>
 
 	* configure.ac: Probe for `help2man'.
Index: font/manager.c
===================================================================
RCS file: /sources/grub/grub2/font/manager.c,v
retrieving revision 1.11
diff -u -p -r1.11 manager.c
--- font/manager.c	21 Jul 2007 23:32:20 -0000	1.11
+++ font/manager.c	9 Feb 2008 21:22:43 -0000
@@ -40,6 +40,27 @@ struct font
 
 static struct font *font_list;
 
+/* Fill unknown glyph's with rounded question mark.  */
+static grub_uint8_t unknown_glyph[16] =
+{       /* 76543210 */
+  0x7C, /*  ooooo   */
+  0x82, /* o     o  */
+  0xBA, /* o ooo o  */
+  0xAA, /* o o o o  */
+  0xAA, /* o o o o  */
+  0x8A, /* o   o o  */
+  0x9A, /* o  oo o  */
+  0x92, /* o  o  o  */
+  0x92, /* o  o  o  */
+  0x92, /* o  o  o  */
+  0x92, /* o  o  o  */
+  0x82, /* o     o  */
+  0x92, /* o  o  o  */
+  0x82, /* o     o  */
+  0x7C, /*  ooooo   */
+  0x00  /*          */
+};
+
 static int
 add_font (const char *filename)
 {
@@ -154,8 +175,9 @@ fill_with_default_glyph (grub_font_glyph
 {
   unsigned i;
 
+  /* Use pre-defined pattern to fill unknown glyphs.  */
   for (i = 0; i < 16; i++)
-    glyph->bitmap[i] = (i & 1) ? 0x55 : 0xaa;
+    glyph->bitmap[i] = unknown_glyph[i];
 
   glyph->char_width = 1;
   glyph->width = glyph->char_width * 8;

Re: [patch] more descriptive unknown glyph picture

[Robert Millan]

On Sat, Feb 09, 2008 at 11:27:22PM +0200, Vesa Jääskeläinen wrote:
> Hi All,
> 
> Here is a patch that changes this gray pattern for unknown glyphs to 
> rounded question mark. This way user knows that something is missing :) 
> (and it is easily visible).
> 
> Another story is, should we provide default fonts and/or use system 
> fonts where available.

I think using system fonts is fine.  Current update-grub has logic to detect
them, and enable them when present.  It checks (via grub-probe) that GRUB will
be able to read them before doing so.  Additionaly, the grub.cfg it generates
will instruct GRUB to fallback sanely to console when fonts aren't readable.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

Re: [patch] more descriptive unknown glyph picture

[Pavel Roskin]

On Sat, 2008-02-09 at 23:06 +0100, Robert Millan wrote:

> I think using system fonts is fine.  Current update-grub has logic to detect
> them, and enable them when present.  It checks (via grub-probe) that GRUB will
> be able to read them before doing so.  Additionaly, the grub.cfg it generates
> will instruct GRUB to fallback sanely to console when fonts aren't readable.

You probably misunderstand.  System fonts are located in BIOS.  I think
it might also be possible to read them back from a VGA compatible card.

-- 
Regards,
Pavel Roskin

Re: [patch] more descriptive unknown glyph picture

[Vesa Jääskeläinen]

Vesa Jääskeläinen wrote:
> Here is a patch that changes this gray pattern for unknown glyphs to 
> rounded question mark. This way user knows that something is missing :) 
> (and it is easily visible).

Committed.

Re: [patch] more descriptive unknown glyph picture

[Vesa Jääskeläinen]

Pavel Roskin wrote:
> On Sat, 2008-02-09 at 23:06 +0100, Robert Millan wrote:
> 
>> I think using system fonts is fine.  Current update-grub has logic to detect
>> them, and enable them when present.  It checks (via grub-probe) that GRUB will
>> be able to read them before doing so.  Additionaly, the grub.cfg it generates
>> will instruct GRUB to fallback sanely to console when fonts aren't readable.
> 
> You probably misunderstand.  System fonts are located in BIOS.  I think
> it might also be possible to read them back from a VGA compatible card.

This is what I was pointing to. But there are most likely systems where 
this font information is stored elsewhere. And actually VGA font sizes 
are usually too small for larger displays. (and so is ours)

Re: [patch] more descriptive unknown glyph picture

[Robert Millan]

On Sat, Feb 09, 2008 at 06:01:31PM -0500, Pavel Roskin wrote:
> On Sat, 2008-02-09 at 23:06 +0100, Robert Millan wrote:
> 
> > I think using system fonts is fine.  Current update-grub has logic to detect
> > them, and enable them when present.  It checks (via grub-probe) that GRUB will
> > be able to read them before doing so.  Additionaly, the grub.cfg it generates
> > will instruct GRUB to fallback sanely to console when fonts aren't readable.
> 
> You probably misunderstand.  System fonts are located in BIOS.  I think
> it might also be possible to read them back from a VGA compatible card.

Sorry, I wasn't very explicit.  When I said system fonts I meant e.g. unicode.pff.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)