Re: [Xenomai-core] [patch 0/4] Support for select-like services.

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

Gilles Chanteperdrix wrote:
> Hi,
> 
> here comes a third edition of the patchset adding support for select. 
> 
> The core support now depends on a CONFIG_XENO_OPT_SELECT option, whereas the
> posix support depends on a CONFIG_XENO_OPT_POSIX_SELECT option.
> 
> The support for using rtdm_event_t and rtdm_sem_t objects is now built-in to
> these objects without creating new objects types (only if
> CONFIG_XENO_OPT_SELECT is enabled).
> 
> The rtdm_context_get modification, allowing to check that the caller of a service
> belongs to the same process as the file descriptor it uses, is now made in
> __rtdm_context_get while rtdm_context_get passes a NULL first argument to this
> new service.
> 
> When implementing these modifications, a few questions arise:
> - RTDM support currently depends on the CONFIG_XENO_OPT_SELECT option, should we
> add an RTDM specific option ?

IIRC, the policy is so far that the skin selects the nucleus features it
wants/needs, so we may better add the visible switch to RTDM as well.

> - in order to avoid numerous #ifdefs, and especially in drivers code, the new
> callback added to device operations for binding RTDM file descriptors to
> selector blocks is always there even if CONFIG_XENO_OPT_SELECT is disabled. Is
> it the right thing to do ?

That's ok, otherwise ifdef'ery would crawl into the drivers as well.
Given the conversion you posted for RTnet, we don't add noticeable bloat
this way.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]