From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JOIj3-00089r-MH for mharc-grub-devel@gnu.org; Sun, 10 Feb 2008 15:24:33 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JOIj2-00089l-FX for grub-devel@gnu.org; Sun, 10 Feb 2008 15:24:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JOIj1-00089U-JS for grub-devel@gnu.org; Sun, 10 Feb 2008 15:24:31 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JOIj1-00089R-Es for grub-devel@gnu.org; Sun, 10 Feb 2008 15:24:31 -0500 Received: from mute.marlboro.edu ([206.192.68.75]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JOIj1-0007iw-ER for grub-devel@gnu.org; Sun, 10 Feb 2008 15:24:31 -0500 Received: from akbar.marlboro.edu (akbar.marlboro.edu [10.1.2.5]) by mute.marlboro.edu (Postfix) with ESMTP id A42861F936D for ; Sun, 10 Feb 2008 15:24:24 -0500 (EST) Received: from xyz.marlboro.edu (xyz.marlboro.edu [10.1.2.29]) by akbar.marlboro.edu (Postfix) with ESMTP id 9FDA011E55D for ; Sun, 10 Feb 2008 15:24:24 -0500 (EST) Received: from [10.1.4.164] (mdhcp164.marlboro.edu [10.1.4.164]) by xyz.marlboro.edu (Postfix) with ESMTP id 1561C3AC12C for ; Sun, 10 Feb 2008 16:27:22 -0500 (EST) Message-ID: <47AF5D8B.1000000@isaac.cedarswampstudios.org> Date: Sun, 10 Feb 2008 15:24:43 -0500 From: Isaac Dupree User-Agent: Thunderbird 2.0.0.6 (X11/20071022) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080208161855.GA19377@thorin> <200802100810.13574.okuji@enbug.org> <20080210125533.GF1828@thorin> <200802102107.27787.okuji@enbug.org> In-Reply-To: <200802102107.27787.okuji@enbug.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Marlboro-MailScanner: Found to be clean, clean X-Marlboro-MailScanner-From: id@isaac.cedarswampstudios.org X-Marlboro-MailScanner-Information: Please contact techsupport@marlboro.edu for more information X-Marlboro-SpamCheck: not spam (whitelisted), SpamAssassin (not cached, score=-4.399, required 6, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -2.60) X-MailScanner-From: id@isaac.cedarswampstudios.org X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] if timeout is set to zero, don't bother drawing the menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2008 20:24:32 -0000 Yoshinori K. Okuji wrote: > On Sunday 10 February 2008 13:55, Robert Millan wrote: >> We could make the behaviour be, that if ESC is pressed at any time before >> an input line is completed, the operation is aborted, read returns >> non-zero, and it doesn't save the line to any variable. What do you think? > > Not bad. :) :) >>> In GRUB Legacy, the hidden menu uses ESC, because if it uses ENTER, and >>> the user pushes ENTER too long, and a key repeat occurs, then the first >>> item may be selected quick as a flash. But we could avoid this problem by >>> vacuuming all inputs before showing a menu, so it might be acceptable to >>> use ENTER instead. >> This is still error-prone. Even if you vacuum the input buffer, we still >> have a race between user unholding ENTER and GRUB showing the menu. >> Vacuuming the buffer just gives us more time, but doesn't garantee good >> results. > > Sure, but I think it would be good enough in reality. most realities. Probably it will bite someone some day. A 1/10th second delay or so after display before listening for input might reduce the chances of that, though increase the very same chances of the enter-press for the menu being intentional but dropped. -Isaac