From: Saeed Bishara <saeed@marvell.com>
To: Mark Lord <liml@rtr.ca>
Cc: Byron Bradley <byron.bbradley@gmail.com>,
linux-ide@vger.kernel.org, mlord@pobox.com, jeff@garzik.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: sata_mv: problems using it as a platform_driver
Date: Mon, 11 Feb 2008 08:06:45 -0500 [thread overview]
Message-ID: <47B04865.2070007@marvell.com> (raw)
In-Reply-To: <47ABDC1C.9050507@rtr.ca>
Mark Lord wrote:
> Byron Bradley wrote:
>> I'm having problems getting the sata_mv driver working as a platform
>> driver on the QNAP TS-209 and the Linkstation/Kurobox (both are Marvell
>> Orion 88f5182 based devices). First of all it would oops in
>> mv_port_start() while calling dma_pool_alloc(), the patch to fix this is
>> at the end of this email.
> ..
>
> Ouch. I'd say this is proof-positive that Saeed did not even test his
> latest patches. Your fix below looks straightforward and correct.
you're right, the fix is definitely needed, seems I was checking the wrong image :(.
>
prev parent reply other threads:[~2008-02-11 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 1:33 sata_mv: problems using it as a platform_driver Byron Bradley
2008-02-08 2:20 ` Byron Bradley
2008-02-08 4:42 ` Mark Lord
2008-02-11 13:35 ` Saeed Bishara
2008-02-12 1:31 ` Tejun Heo
2008-02-08 4:35 ` Mark Lord
2008-02-11 13:06 ` Saeed Bishara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B04865.2070007@marvell.com \
--to=saeed@marvell.com \
--cc=byron.bbradley@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.