All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Manfred Spraul <manfred@colorfullife.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Ayaz Abdulla <aabdulla@nvidia.com>,
	Tom Herbert <therbert@google.com>
Subject: Re: [PATCH] forcedeth: seperate handler for msix and normal int.
Date: Mon, 11 Feb 2008 10:36:59 -0500	[thread overview]
Message-ID: <47B06B9B.1000801@garzik.org> (raw)
In-Reply-To: <200712291415.47835.yinghai.lu@sun.com>

Yinghai Lu wrote:
> [PATCH] forcedeth: seperate handler for msix and normal int.
> 
> so we don't need to keep checking np->msi_flags to see if NV_MSI_X_ENABLED is set in
> handler
> 
> Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>

Two comments:

* can you regenerate this on top of 2.6.25-rc1?

* take a look at the 'fe' branch of 
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

and see what you think about the work in there.  We need to get cleanups 
like that (and more) upstream.  It also intersects with Tom @ Google's 
"Reduce locking in TX path" patch.

	Jeff




  parent reply	other threads:[~2008-02-11 15:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-29 22:15 [PATCH] forcedeth: seperate handler for msix and normal int Yinghai Lu
2007-12-30 14:47 ` Ingo Molnar
2008-02-11 15:36 ` Jeff Garzik [this message]
2008-02-12  0:52   ` [PATCH] forcedeth: seperate handler for msix and normal int v2 Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B06B9B.1000801@garzik.org \
    --to=jeff@garzik.org \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=aabdulla@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mingo@elte.hu \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.