All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: SIMPLE_ATTRIBUTE_GETTER compile fix
Date: Tue, 12 Feb 2008 14:26:12 +0200	[thread overview]
Message-ID: <47B19064.40709@qumranet.com> (raw)
In-Reply-To: <20080212115255.GQ7051@v2.random>

Andrea Arcangeli wrote:
> Hello,
>
> this GETTER stuff looks a bit tricky... (we've just to cope with it).
>
> Anyway this allows building again and perhaps there's something good
> in the patch (not sure about the >= 2.6.25 side that I didn't touch)
>
> Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>  
>
> diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h
> index 3b45999..fe6108c 100644
> --- a/kernel/external-module-compat.h
> +++ b/kernel/external-module-compat.h
> @@ -658,7 +664,7 @@ static inline struct page *__kvm_vm_fault(struct vm_area_struct *vma,
>  	{				      \
>  		u64 ret = 0;		      \
>  					      \
> -		__##x(v, &ret);		      \
> +		__##x(v);		      \
>  		return ret;		      \
>  	}
>   
But, getters are defined as

> static int vm_stat_get(void *_offset, u64 *val)

Perhaps you have an old kvm.git?

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-12 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 11:52 SIMPLE_ATTRIBUTE_GETTER compile fix Andrea Arcangeli
2008-02-12 12:26 ` Avi Kivity [this message]
2008-02-12 12:34   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B19064.40709@qumranet.com \
    --to=avi@qumranet.com \
    --cc=andrea@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.