All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jeff@garzik.org, linux-ide@vger.kernel.org, liml@rtr.ca,
	alan@lxorguk.ukuu.org.uk, kngregertsen@norway.atmel.com,
	sonic.adi@gmail.com, rmk@arm.linux.org.uk,
	alessandro.zummo@towertech
Subject: How to verify sht-ops-conversion patch doesn't change anything
Date: Tue, 12 Feb 2008 22:25:54 +0900	[thread overview]
Message-ID: <47B19E62.9030601@gmail.com> (raw)
In-Reply-To: <1202805801343-git-send-email-htejun@gmail.com>

The fifth and sixth patch, cleanup-sht and cleanup-ops, can be
verified not to change the final sht and ops by printing out all
entries and comparing the values before and after.

1. Get the following git branch.

   http://git.kernel.org/?p=linux/kernel/git/tj/libata-dev.git;a=shortlog;h=cleanup-sht-ops-verify-before
   git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata-dev.git cleanup-sht-ops-verify-before

   Build the kernel with the libata modules to verify and run the
   following command.

   # insmod libata.ko; for i in $(ls *.ko | sort | grep -v libata.ko); do insmod $i; done; dmesg -c | grep -E 'SHT|OPS' | sed -r 's/^\[[ \.0-9]*\] (.*)$/\1/' | sort > ~/out.before

   If you need some libata modules built-in for rootfs, it's okay too.
   It will give the same result.

2. Get the following git branch.

   http://git.kernel.org/?p=linux/kernel/git/tj/libata-dev.git;a=shortlog;h=cleanup-sht-ops-verify-after
   git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata-dev.git cleanup-sht-ops-verify-after

   # insmod libata.ko; for i in $(ls *.ko | sort | grep -v libata.ko); do insmod $i; done; dmesg -c | grep -E 'SHT|OPS' | sed -r 's/^\[[ \.0-9]*\] (.*)$/\1/' | sort > ~/out.after

3. Use your favorite diff program to compare out.before and out.after.
   Graphical ones which show in-line differences will work best.

Thanks.

-- 
tejun

  parent reply	other threads:[~2008-02-12 13:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12  8:43 [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations, take #2 Tejun Heo
2008-02-12  8:43 ` [PATCH 01/10] libata: PCI device should be powered up before being accessed Tejun Heo
2008-02-12  8:43 ` [PATCH 02/10] libata: reorganize ata_port_operations Tejun Heo
2008-02-12  8:43 ` [PATCH 03/10] libata: implement and use ata_noop_irq_clear() Tejun Heo
2008-02-12  8:43 ` [PATCH 04/10] libata: normalize port_info, port_operations and sht tables Tejun Heo
2008-02-12  8:43 ` [PATCH 05/10] libata: implement and use SHT initializers Tejun Heo
2008-02-12  8:43 ` [PATCH 06/10] libata: implement and use ops inheritance Tejun Heo
2008-02-12  8:43 ` [PATCH 07/10] libata: make ata_pci_init_one() not use ops->irq_handler and pi->sht Tejun Heo
2008-02-12  8:43 ` [PATCH 08/10] libata: stop overloading port_info->private_data Tejun Heo
2008-02-12  8:43 ` [PATCH 09/10] libata: kill port_info->sht and ->irq_handler Tejun Heo
2008-02-12  8:43 ` [PATCH 10/10] libata: make reset related methods proper port operations Tejun Heo
2008-02-12 13:25 ` Tejun Heo [this message]
2008-02-12 23:55 ` [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations, take #2 Akira Iguchi
2008-02-13  0:03   ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2008-01-30  9:28 [PATCHSET libata-dev#upstream] clean up scsi_host_templates and ata_port_operations Tejun Heo
2008-01-30  9:49 ` How to verify sht-ops-conversion patch doesn't change anything Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B19E62.9030601@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alessandro.zummo@towertech \
    --cc=jeff@garzik.org \
    --cc=kngregertsen@norway.atmel.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sonic.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.