From: Scott Wood <scottwood@freescale.com>
To: Stefan Roese <sr@denx.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: Fix physmap_of to not exit upon unsuccessful partition scan
Date: Tue, 12 Feb 2008 12:06:34 -0600 [thread overview]
Message-ID: <47B1E02A.3090709@freescale.com> (raw)
In-Reply-To: <1202832181-1783-1-git-send-email-sr@denx.de>
Stefan Roese wrote:
> The patch 9a310d21196f38f6ad0ad146057548653e495c09 ("[MTD] Factor out OF
> partition support from the NOR driver.") introduced an problem. Now the
> physmap_of driver returns with error upon the first unsuccessful
> partition scan (parse_mtd_partitions()). This is not wanted, since even
> when the RedBoot/cmdlinepart partition scan is unsuccessful, the other
> scan's (of_mtd_parse_partitions(), parse_obsolete_partitions()) should be
> done nevertheless.
>
> This patch fixes this problem.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>
> Scott, could you please take a look at this patch and add you ACK if you
> think it is ok?
I was under the impression -- and looking at the code seems to back that
up -- that parse_mtd_partitions() returns zero if the scan was
unsuccessful due to the lack of a partition table, and negative only if
there's a real error.
Under what conditions are you actually seeing this fail?
-Scott
next prev parent reply other threads:[~2008-02-12 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 16:03 [PATCH] mtd: Fix physmap_of to not exit upon unsuccessful partition scan Stefan Roese
2008-02-12 18:06 ` Scott Wood [this message]
2008-02-12 19:15 ` Stefan Roese
2008-02-12 19:27 ` Scott Wood
2008-02-12 19:37 ` Stefan Roese
2008-02-14 12:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B1E02A.3090709@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.