From: Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: kvm-devel@lists.sourceforge.net,
Markus Rechberger <markus.rechberger@amd.com>
Subject: Re: [PATCH 3/3] KVM: SVM: enable LBRV virtualization
Date: Wed, 13 Feb 2008 12:20:07 +0200 [thread overview]
Message-ID: <47B2C457.5040908@qumranet.com> (raw)
In-Reply-To: <20080213100354.GA22943@amd.com>
Joerg Roedel wrote:
>>>
>>>
>> This still has the same issue as the previous patchset: if the guest enables some other bit
>> in MSR_IA32_DEBUCTLMSR, we silently ignore it. We should either pr_unimpl() on such bits or
>> not handle them (ultimately injecting a #GP).
>>
>
> Thats not true. The patch saves the MSR value in vmcb->save.dbgctl. This
> value is returned on reads of that MSR. So no bit is ignored. This value
> in the VMCB is also used as the guests copy of that MSR if LBR
> virtualization is enabled.
Right, my mistake.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-13 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 15:27 KVM: SVM: Implement LBRV virtualization Joerg Roedel
2008-02-12 15:27 ` [PATCH 1/3] KVM: SVM: let init_vmcb() take struct vcpu_svm as parameter Joerg Roedel
2008-02-12 15:27 ` [PATCH 2/3] KVM: SVM: allocate the MSR permission map per VCPU Joerg Roedel
2008-02-12 15:27 ` [PATCH 3/3] KVM: SVM: enable LBRV virtualization Joerg Roedel
2008-02-13 9:50 ` Avi Kivity
2008-02-13 10:03 ` Joerg Roedel
2008-02-13 10:20 ` Avi Kivity [this message]
2008-02-12 15:53 ` KVM: SVM: Implement " Maciej Kowalczyk
2008-02-12 16:01 ` Joerg Roedel
2008-02-12 16:35 ` Alexey Eremenko
2008-02-12 17:02 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2C457.5040908@qumranet.com \
--to=avi@qumranet.com \
--cc=joerg.roedel@amd.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=markus.rechberger@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.