From: Avi Kivity <avi@qumranet.com>
To: Anders Melchiorsen <mail@flac.kalibalik.dk>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: Signals for file descriptors
Date: Wed, 13 Feb 2008 14:10:04 +0200 [thread overview]
Message-ID: <47B2DE1C.3070009@qumranet.com> (raw)
In-Reply-To: <87ejbhgj05.fsf@dylle.kalibalik.dk>
Anders Melchiorsen wrote:
> I am wondering about this commit,
>
> http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=b4e392c21c4b98c1c13af353caa3d6e6bcb6b8af
>
> which adds signals on tap I/O. It seems a bit half-done to me. For one
> thing, it is mixing timers with I/O.
>
>
The signal handler doesn't actually matter; all that's needed is to
break out of the loop.
> Anyway, my question is about the remaining file descriptors. Should
> signals be activated for them as well, for example in
> qemu_set_fd_handler2() ? My example on hand is that connecting a VNC
> client currently delays until the next timer expiry.
In practice it doesn't matter, but yes, any fd which we will select()
needs to have a signal attached.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-13 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 12:04 Signals for file descriptors Anders Melchiorsen
2008-02-13 12:10 ` Avi Kivity [this message]
2008-02-13 12:22 ` Anders Melchiorsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2DE1C.3070009@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mail@flac.kalibalik.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.