All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
To: linux-btrace@vger.kernel.org
Subject: Re: [PATCH] btt: fix missing cleanup call
Date: Wed, 13 Feb 2008 16:50:58 +0000	[thread overview]
Message-ID: <47B31FF2.7070800@hp.com> (raw)
In-Reply-To: <47B2A0BE.1030709@gelato.unsw.edu.au>

Aaron Carroll wrote:
> clean_args() exists but is never called, thus any files opened in args remain
> open while the buffers backing those files are closed.
> 
> Signed-off-by: Aaron Carroll <aaronc@gelato.unsw.edu.au>
> ---
>  btt/bt_timeline.c |    1 +
>  btt/globals.h     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/btt/bt_timeline.c b/btt/bt_timeline.c
> index 981b909..17a1b23 100644
> --- a/btt/bt_timeline.c
> +++ b/btt/bt_timeline.c
> @@ -92,6 +92,7 @@ int main(int argc, char *argv[])
>  	free(input_name);
>  	if (output_name) free(output_name);
>  
> +	clean_args();
>  	clean_bufs();
>  
>  	return 0;
> diff --git a/btt/globals.h b/btt/globals.h
> index f6041de..486a3fc 100644
> --- a/btt/globals.h
> +++ b/btt/globals.h
> @@ -228,6 +228,7 @@ extern struct list_head cios;
>  
>  /* args.c */
>  void handle_args(int argc, char *argv[]);
> +void clean_args();
>  
>  /* devmap.c */
>  int dev_map_read(char *fname);
> 

Looks good, applied, thanks!

Alan

      reply	other threads:[~2008-02-13 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  7:48 [PATCH] btt: fix missing cleanup call Aaron Carroll
2008-02-13 16:50 ` Alan D. Brunelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B31FF2.7070800@hp.com \
    --to=alan.brunelle@hp.com \
    --cc=linux-btrace@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.