From: Brice Goglin <Brice.Goglin@inria.fr>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Ingo Molnar <mingo@elte.hu>,
Paul Mundt <lethal@linux-sh.org>, Chris Snook <csnook@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: Purpose of numa_node?
Date: Wed, 13 Feb 2008 19:52:06 +0100 [thread overview]
Message-ID: <47B33C56.3070502@inria.fr> (raw)
In-Reply-To: <86802c440801311535v2bb9977ma884129662c9a2d5@mail.gmail.com>
Yinghai Lu wrote:
>>> Have a look at the above link. I don't get -1. I get 0 everywhere, while
>>> I should get 1 for some devices. And if I unplug/replug a device using
>>> fakephp, numa_node becomes correct (1 instead of 0). This just looks
>>> like the code is there but things are initialized in the wrong order.
>>>
>> do you have
>> ...
>> bus 00 -> pxm 0 -> node 0
>> ...
>> bus 40 -> pxm 1 -> node 1
>> ...
>> bus 80 -> pxm 1 -> node 1
>>
>> in your boot msg or dmesg?
>>
>> if not, your dsdt doesn't have _PXM for pci root bus. or you need to
>> ask your HW vendor to add that in their BIOS, or use my patchset.
>>
>
> please try the attached patchset
>
> please get x86.git then use quilt apply the patch
>
> http://people.redhat.com/mingo/x86.git/README
>
I finally managed to test this and it seems to work. I now get the
following numa_node attributes:
/sys/devices/pci0000:00/0000:00:01.0/numa_node 0
/sys/devices/pci0000:00/0000:00:07.0/numa_node 0
/sys/devices/pci0000:00/0000:00:07.0/0000:38:0d.0/numa_node 0
/sys/devices/pci0000:00/0000:00:08.0/numa_node 0
/sys/devices/pci0000:00/0000:00:08.1/numa_node 0
/sys/devices/pci0000:00/0000:00:08.2/numa_node 0
/sys/devices/pci0000:00/0000:00:09.0/numa_node 0
/sys/devices/pci0000:00/0000:00:09.1/numa_node 0
/sys/devices/pci0000:00/0000:00:09.2/numa_node 0
/sys/devices/pci0000:00/0000:00:0a.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0a.0/0000:22:00.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0b.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0c.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0c.0/0000:0c:00.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0c.0/0000:0c:00.0/0000:0d:00.0/numa_node
0
/sys/devices/pci0000:00/0000:00:0d.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0d.0/0000:01:00.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0e.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0e.0/0000:17:00.0/numa_node 0
/sys/devices/pci0000:00/0000:00:0e.0/0000:17:00.0/0000:18:00.0/numa_node
0
/sys/devices/pci0000:00/0000:00:18.0/numa_node 0
/sys/devices/pci0000:00/0000:00:18.1/numa_node 0
/sys/devices/pci0000:00/0000:00:18.2/numa_node 0
/sys/devices/pci0000:00/0000:00:18.3/numa_node 0
/sys/devices/pci0000:00/0000:00:19.0/numa_node 0
/sys/devices/pci0000:00/0000:00:19.1/numa_node 0
/sys/devices/pci0000:00/0000:00:19.2/numa_node 0
/sys/devices/pci0000:00/0000:00:19.3/numa_node 0
/sys/devices/pci0000:00/0000:00:1a.0/numa_node 0
/sys/devices/pci0000:00/0000:00:1a.1/numa_node 0
/sys/devices/pci0000:00/0000:00:1a.2/numa_node 0
/sys/devices/pci0000:00/0000:00:1a.3/numa_node 0
/sys/devices/pci0000:00/0000:00:1b.0/numa_node 0
/sys/devices/pci0000:00/0000:00:1b.1/numa_node 0
/sys/devices/pci0000:00/0000:00:1b.2/numa_node 0
/sys/devices/pci0000:00/0000:00:1b.3/numa_node 0
/sys/devices/pci0000:40/0000:40:0f.0/numa_node 1
/sys/devices/pci0000:40/0000:40:10.0/numa_node 1
/sys/devices/pci0000:40/0000:40:11.0/numa_node 1
/sys/devices/pci0000:40/0000:40:12.0/numa_node 1
/sys/devices/pci0000:40/0000:40:12.0/0000:51:00.0/numa_node 1
/sys/devices/pci0000:40/0000:40:13.0/numa_node 1
The 5 last lines above would report 0 instead of 1 with an older kernel.
Everything looks correct now (0000:40 is the second PCIe bus and it is
attached to socket #1).
Thanks a lot, Yinghai! Are you planning to merge these patches in the
near future? 2.6.26?
Brice
PS: I saved the corresponding dmesg. If you want to look at it, please
let me know.
next prev parent reply other threads:[~2008-02-13 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 0:48 Purpose of numa_node? Chris Snook
2008-01-31 7:40 ` Paul Mundt
2008-01-31 9:56 ` Andi Kleen
2008-01-31 13:42 ` Brice Goglin
2008-01-31 21:29 ` Yinghai Lu
2008-01-31 21:35 ` Brice Goglin
2008-01-31 21:42 ` Yinghai Lu
2008-01-31 23:35 ` Yinghai Lu
2008-02-13 18:52 ` Brice Goglin [this message]
2008-02-13 21:31 ` Yinghai Lu
2008-02-20 21:55 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B33C56.3070502@inria.fr \
--to=brice.goglin@inria.fr \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=csnook@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.