From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JPZX9-0001OI-C0
	for mharc-grub-devel@gnu.org; Thu, 14 Feb 2008 03:33:31 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JPZX7-0001Li-CL
	for grub-devel@gnu.org; Thu, 14 Feb 2008 03:33:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JPZX5-0001JN-9L
	for grub-devel@gnu.org; Thu, 14 Feb 2008 03:33:28 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JPZX4-0001J7-N0
	for grub-devel@gnu.org; Thu, 14 Feb 2008 03:33:26 -0500
Received: from mx2.rz.ruhr-uni-bochum.de ([134.147.64.30])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <greffrath@leat.rub.de>) id 1JPZX4-0007Oy-86
	for grub-devel@gnu.org; Thu, 14 Feb 2008 03:33:26 -0500
X-Queued: (qmail 31085 invoked by uid 281); 14 Feb 2008 08:33:25 -0000
X-Qmailscanner: from 134.147.252.214 by mx2.rz.ruhr-uni-bochum.de
	(envelope-from <greffrath@leat.rub.de>,
	uid 80) with qmail-scanner-2.01 (sophie: 3.05/2.52/4.24.  
	Clear:RC:1(134.147.252.214):. 
	Processed in 0.039577 secs); 14 Feb 2008 08:33:25 -0000
Received: from router.leat.ruhr-uni-bochum.de (134.147.252.214)
	by mx2.rz.ruhr-uni-bochum.de with SMTP; 14 Feb 2008 08:33:24 -0000
Received: from [134.147.55.45] (frodo.leat.ruhr-uni-bochum.de [134.147.55.45])
	by router.leat.ruhr-uni-bochum.de (8.12.2/8.12.2/SuSE Linux 0.6)
	with ESMTP id m1E8cZ1l021762
	for <grub-devel@gnu.org>; Thu, 14 Feb 2008 09:38:35 +0100
Message-ID: <47B3FCEC.6020107@leat.rub.de>
Date: Thu, 14 Feb 2008 09:33:48 +0100
From: Fabian Greffrath <greffrath@leat.rub.de>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <47B19C57.9020902@leat.rub.de>
	<20080213154224.GB30040@thorin>	<47B32029.200@leat.rub.de>
	<20080213193534.GA28711@thorin>
In-Reply-To: <20080213193534.GA28711@thorin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6
Subject: Re: [PATCH] Add option to grub-probe to accept system devices as
 arguments
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2008 08:33:29 -0000

Robert Millan schrieb:
> The last one sounds like a bug.

Yes, it's from the current *unpatched* grub-probe.

> Yes, but does the user know that? 

We could tell the user via 'grub-probe --help' that he may pass either a path or 
a block device as an argument.

> Which interface is easier to figure out
> for the user, one in which different actions require different parameters,
> or one where the same parameters act in completely different way depending
> on the file?

There are no different actions! Whether you give a valid path or a block device 
as an argument, the program behaves exactly the same. It does even behave 
exactly as before (i.e. unpatched) if given a path. Accepting devices as 
argument is simply an *added* feature.