Re: [PATCH] ext4: Fix kernel BUG at fs/ext4/mballoc.c:910!

[Valerie Clement <valerie.clement@bull.net>]

Aneesh Kumar K.V wrote:
>>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>>> index b0f84b4..0275150 100644
>>> --- a/fs/ext4/mballoc.c
>>> +++ b/fs/ext4/mballoc.c
>>> @@ -907,7 +907,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb,
>>>  	unsigned short chunk;
>>>  	unsigned short border;
>>>  
>>> -	BUG_ON(len >= EXT4_BLOCKS_PER_GROUP(sb));
>>> +	BUG_ON(len > EXT4_BLOCKS_PER_GROUP(sb));
>>>  
>>>  	border = 2 << sb->s_blocksize_bits;
>>>  
>>> @@ -3286,7 +3286,7 @@ static void ext4_mb_normalize_request(struct ext4_allocation_context *ac,
>>>  	}
>>>  	BUG_ON(start + size <= ac->ac_o_ex.fe_logical &&
>>>  			start > ac->ac_o_ex.fe_logical);
>>> -	BUG_ON(size <= 0 || size >= EXT4_BLOCKS_PER_GROUP(ac->ac_sb));
>>> +	BUG_ON(size <= 0 || size > EXT4_BLOCKS_PER_GROUP(ac->ac_sb));
> 
> I am not sure about this. Here size is the normalized request len. 
> Did we hit this BUG_ON ?
In fact, no. So, I'll not make the change now.
Thanks for your response and your explanations.
    Valerie