All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: Mel Gorman <mel@csn.ul.ie>, Nick Piggin <npiggin@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [patch 2/5] slub: Fallback to kmalloc_large for failing higher order allocs
Date: Thu, 14 Feb 2008 21:47:41 +0200	[thread overview]
Message-ID: <47B49ADD.9010001@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0802141128430.375@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> That would mean reducing the number of objects that can be allocated from 
> the fastpath before we have to go to the page allocator again. Increasing 
> the number of fastpath uses vs slowpath increases the overall performance 
> of a slab.
> 
> If we would use order 0 slab allocs for 4k slabs then every call to 
> slab_alloc would lead to a corresponding call to the page allocator. The 
> regression would not be fixed. We just add slab_alloc overhead to an 
> already bad page allocator call.

Aah, I see. I wonder if we can fix up allocate_slab() to try with a 
smaller order as long as the size allows that? The only problem I can 
see is s->objects but I think we can just move that to be a per-slab 
variable. So sort of variable-order slabs kind of a thing.

What do you think?

			Pekka

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-02-14 19:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080214040245.915842795@sgi.com>
     [not found] ` <20080214040314.388752493@sgi.com>
2008-02-14  7:14   ` [patch 5/5] slub: Large allocs for other slab sizes that do not fit in order 0 Pekka Enberg
2008-02-14 19:06     ` Christoph Lameter
2008-02-14  8:55   ` Pekka Enberg
     [not found] ` <20080214040313.318658830@sgi.com>
2008-02-14  7:23   ` [patch 1/5] slub: Determine gfpflags once and not every time a slab is allocated Pekka Enberg
2008-02-14 13:55   ` Mel Gorman
     [not found] ` <20080214040313.616551392@sgi.com>
2008-02-14  7:04   ` [patch 2/5] slub: Fallback to kmalloc_large for failing higher order allocs Pekka Enberg
2008-02-14  8:56   ` Pekka Enberg
2008-02-14 19:07     ` Christoph Lameter
2008-02-14 14:06   ` Mel Gorman
2008-02-14 19:10     ` Christoph Lameter
2008-02-14 19:23       ` Pekka Enberg
2008-02-14 19:32         ` Christoph Lameter
2008-02-14 19:47           ` Pekka Enberg [this message]
2008-02-14 19:57             ` Christoph Lameter
2008-02-14 20:02               ` Pekka Enberg
2008-02-14 20:08                 ` Christoph Lameter
2008-02-14 20:13                   ` Pekka Enberg
     [not found] ` <20080214040314.118141086@sgi.com>
2008-02-14  7:07   ` [patch 4/5] slub: Use __GFP_MOVABLE for slabs of HPAGE_SIZE Pekka Enberg
2008-02-14 19:04     ` Christoph Lameter
2008-02-14  8:57   ` Pekka Enberg
2008-02-14 19:07     ` Christoph Lameter
2008-02-14 14:14   ` Mel Gorman
2008-02-14 19:18     ` Christoph Lameter
2008-02-14 20:08       ` Mel Gorman
2008-02-14 20:14         ` Christoph Lameter
2008-02-14 20:25           ` Mel Gorman
2008-02-14 20:32             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B49ADD.9010001@cs.helsinki.fi \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.