From: Andi Kleen <andi@firstfloor.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
torvalds@osdl.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix left over EFI cache mapping problems
Date: Fri, 15 Feb 2008 10:43:08 +0100 [thread overview]
Message-ID: <47B55EAC.10002@firstfloor.org> (raw)
In-Reply-To: <1203067262.30010.34.camel@caritas-dev.intel.com>
Huang, Ying wrote:
> On Fri, 2008-02-15 at 09:48 +0100, Andi Kleen wrote:
>> On Fri, Feb 15, 2008 at 12:48:06PM +0800, Huang, Ying wrote:
>>> This patch has been tested on Intel x86 platform with EFI 32/64.
>> Can EFI_PAGE_SIZE ever be < 4k? If yes you would need to round up
>> first to linux page size before shifting.
>
> Yes. It is needed. And md->virt_addr should be processed as follow:
>
> md->virt_addr & PAGE_MASK
>
> before fed into set_memory_*.
If you do that you also need to add the old offset into the page
to the size.
I just mention it because ioremap_change_attr() did that wrong
before my patch yesterday :)
-Andi
prev parent reply other threads:[~2008-02-15 9:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 13:13 [PATCH] Fix left over EFI cache mapping problems Andi Kleen
2008-02-14 16:12 ` Ingo Molnar
2008-02-14 17:16 ` Andi Kleen
2008-02-14 18:38 ` Ingo Molnar
2008-02-14 21:42 ` Andi Kleen
2008-02-14 22:08 ` Arjan van de Ven
2008-02-14 23:01 ` Andi Kleen
2008-02-15 2:52 ` Huang, Ying
2008-02-15 8:55 ` Andi Kleen
2008-02-15 9:16 ` Huang, Ying
2008-02-15 4:48 ` Huang, Ying
2008-02-15 5:44 ` Linus Torvalds
2008-02-15 6:24 ` Huang, Ying
2008-02-15 7:30 ` Ingo Molnar
2008-02-15 7:08 ` Ingo Molnar
2008-02-15 7:32 ` Huang, Ying
2008-02-18 1:53 ` Huang, Ying
2008-02-18 11:26 ` Andi Kleen
2008-02-18 14:05 ` Ingo Molnar
2008-02-15 8:48 ` Andi Kleen
2008-02-15 9:21 ` Huang, Ying
2008-02-15 9:43 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B55EAC.10002@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.