From: Roel Kluin <12o3l@tiscali.nl>
To: hpa@zytor.com
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)
Date: Sat, 16 Feb 2008 16:58:08 +0100 [thread overview]
Message-ID: <47B70810.5030608@tiscali.nl> (raw)
Not entirely sure who to send this to
---
Replace !likely(x) by likely(!x)
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/kernel/exit.c b/kernel/exit.c
index 506a957..df207fc 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1497,7 +1497,7 @@ repeat:
/*
* We don't reap group leaders with subthreads.
*/
- if (!likely(options & WEXITED))
+ if (likely(!(options & WEXITED)))
continue;
retval = wait_task_zombie(p,
(options & WNOWAIT), infop,
@@ -1508,7 +1508,7 @@ repeat:
* exit, stop, or stop and then continue.
*/
flag = 1;
- if (!unlikely(options & WCONTINUED))
+ if (unlikely(!(options & WCONTINUED)))
continue;
retval = wait_task_continued(p,
(options & WNOWAIT), infop,
diff --git a/kernel/power/process.c b/kernel/power/process.c
index 7c2118f..b42254b 100644
--- a/kernel/power/process.c
+++ b/kernel/power/process.c
@@ -36,7 +36,7 @@ static inline int freezeable(struct task_struct * p)
*/
static inline void frozen_process(void)
{
- if (!unlikely(current->flags & PF_NOFREEZE)) {
+ if (unlikely(!(current->flags & PF_NOFREEZE))) {
current->flags |= PF_FROZEN;
wmb();
}
diff --git a/kernel/signal.c b/kernel/signal.c
index 84917fe..1155e16 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1308,7 +1308,7 @@ int send_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)
*/
rcu_read_lock();
- if (!likely(lock_task_sighand(p, &flags))) {
+ if (likely(!lock_task_sighand(p, &flags))) {
ret = -1;
goto out_err;
}
@@ -1548,7 +1548,7 @@ static void do_notify_parent_cldstop(struct task_struct *tsk, int why)
static inline int may_ptrace_stop(void)
{
- if (!likely(current->ptrace & PT_PTRACED))
+ if (likely(!(current->ptrace & PT_PTRACED)))
return 0;
/*
* Are we in the middle of do_coredump?
@@ -1574,7 +1574,7 @@ static int sigkill_pending(struct task_struct *tsk)
{
return ((sigismember(&tsk->pending.signal, SIGKILL) ||
sigismember(&tsk->signal->shared_pending.signal, SIGKILL)) &&
- !unlikely(sigismember(&tsk->blocked, SIGKILL)));
+ unlikely(!sigismember(&tsk->blocked, SIGKILL)));
}
/*
@@ -1625,7 +1625,7 @@ static void ptrace_stop(int exit_code, int clear_code, siginfo_t *info)
spin_unlock_irq(¤t->sighand->siglock);
try_to_freeze();
read_lock(&tasklist_lock);
- if (!unlikely(killed) && may_ptrace_stop()) {
+ if (unlikely(!killed) && may_ptrace_stop()) {
do_notify_parent_cldstop(current, CLD_TRAPPED);
read_unlock(&tasklist_lock);
schedule();
@@ -1717,7 +1717,7 @@ static int do_signal_stop(int signr)
} else {
struct task_struct *t;
- if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
+ if (likely(!(sig->flags & SIGNAL_STOP_DEQUEUED)) ||
unlikely(sig->group_exit_task))
return 0;
/*
next reply other threads:[~2008-02-16 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 15:58 Roel Kluin [this message]
2008-02-16 19:01 ` [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x) H. Peter Anvin
2008-02-16 19:29 ` Roel Kluin
2008-02-16 19:31 ` H. Peter Anvin
2008-02-16 19:52 ` Roel Kluin
2008-02-17 2:33 ` Rene Herman
2008-02-17 3:56 ` H. Peter Anvin
2008-02-17 4:16 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B70810.5030608@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.