From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
ak@suse.de, mingo@elte.hu, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant
Date: Sun, 17 Feb 2008 11:48:58 -0800 [thread overview]
Message-ID: <47B88FAA.9080603@zytor.com> (raw)
In-Reply-To: <20080217190801.GC31968@cvg>
Cyrill Gorcunov wrote:
>
> Yes Sam, I've read Peter and Ingo comments on this patch
> (actually I sent the same patch maybe week ago and Peter
> and Ingo told me that we use %fs,%gs now for stack) but
> as I pointed in comment - this alignment is still using
> by Xen and lguest and even x86. So - it would be really
> usefull for me if someone give me the last point - YES we
> use such an alignment for stack, NO - we don't use it at all.
> I was trying to hadle this myself - but I'm not a specialist
> in this area you know ;)
>
It bugs me quite a bit that paravirt clients contain this hack
open-coded, but that's not *your* fault. There probably should be a
macro to encapsulate the stack pointer location for a specific thread.
-hpa
next prev parent reply other threads:[~2008-02-17 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 15:17 [patch 0/2] x86: vmlinux.lds cleanup Cyrill Gorcunov
2008-02-17 15:17 ` [patch 1/2] x86: lds - Use PAGE_SIZE instead of numeric constant Cyrill Gorcunov
2008-02-17 18:57 ` Sam Ravnborg
2008-02-17 19:09 ` Ingo Molnar
2008-02-17 15:17 ` [patch 2/2] x86: lds - Use THREAD_SIZE " Cyrill Gorcunov
2008-02-17 18:59 ` Sam Ravnborg
2008-02-17 19:08 ` Cyrill Gorcunov
2008-02-17 19:48 ` H. Peter Anvin [this message]
2008-02-17 20:06 ` Cyrill Gorcunov
2008-02-17 20:11 ` H. Peter Anvin
2008-02-17 20:15 ` Cyrill Gorcunov
2008-02-18 14:27 ` Andi Kleen
2008-02-17 19:08 ` Ingo Molnar
2008-02-17 19:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B88FAA.9080603@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.