All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ned Forrester <nforrester-/d+BM93fTQY@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	merrij3-IL7dBOYR4Vg@public.gmane.org,
	Stephen Street
	<stephen-nl6u4wocdmy51APUEpUfAkEOCMrvLtNR@public.gmane.org>
Subject: [Patch 0/1] spi: Fix pxa2xx_spi.c chip select sequence error
Date: Sun, 17 Feb 2008 23:35:29 -0500	[thread overview]
Message-ID: <47B90B11.6000601@whoi.edu> (raw)

My next message of this subject contains a patch for the issue 
initially raised by the thread: "PXA270 SSPSFRM gates chip select ?" 

This patch is created to apply to the development kernel: 2.6.25-rc1.
This kernel has a newly re-organized regs-ssp.h file, and since I
needed to add a new bit definition to that file, it is included in the
patch. However, as noted in the comments to the patch, kernels 2.6.20
(when the bug was introduced) through 2.6.24 have the ssp bit
definitions in pxa-regs.h, so the extra bit needs to be added there
for the earlier versions.

David: 

Is there a defined procedure for distributing patches the can be
applied to different kernel versions, when they won't apply directly?

---

Also note that I am still developing on 2.6.20, and so I have only
tested this code on that version.  Furthermore, I don't use chip
select, so really I just compiled and ran the changes to show that
they do no harm.

David:

Can I assume that you or someone up the chain will go through the
motions of applying this patch to 2.6.25 and showing that it compiles?
I really don't expect any trouble with that.

Scott:

Can you apply the patch to your 2.6.21 tree, and see if it fixes your
original problem?  Note that you will have to add the bit definition 
line to include/asm-arm/arch-pxa/pxa-regs.h, by hand, or alter the 
file names in the patch from regs-ssp.h to pxa-regs.h

-- 
Ned Forrester                                       nforrester-/d+BM93fTQY@public.gmane.org
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

             reply	other threads:[~2008-02-18  4:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18  4:35 Ned Forrester [this message]
     [not found] ` <47B90B11.6000601-/d+BM93fTQY@public.gmane.org>
2008-02-18 22:21   ` [Patch 0/1] spi: Fix pxa2xx_spi.c chip select sequence error J. Scott Merritt
     [not found]     ` <20080218172128.6fd1522c.merrij3-IL7dBOYR4Vg@public.gmane.org>
2008-02-18 23:03       ` Ned Forrester
     [not found]         ` <47BA0ED9.5040501-/d+BM93fTQY@public.gmane.org>
2008-02-20 18:26           ` Ned Forrester
2008-02-20 22:48   ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B90B11.6000601@whoi.edu \
    --to=nforrester-/d+bm93ftqy@public.gmane.org \
    --cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
    --cc=merrij3-IL7dBOYR4Vg@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=stephen-nl6u4wocdmy51APUEpUfAkEOCMrvLtNR@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.