From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
containers@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
Date: Mon, 18 Feb 2008 11:44:20 +0530 [thread overview]
Message-ID: <47B9223C.9020106@linux.vnet.ibm.com> (raw)
In-Reply-To: <47B91EC2.3020805@cn.fujitsu.com>
Li Zefan wrote:
> No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
> be VM_BUG_ON(page).
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not sure
why we can't bug on pc.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2008-02-18 6:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 5:59 [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() Li Zefan
2008-02-18 6:14 ` Balbir Singh [this message]
[not found] ` <47B9223C.9020106-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-02-18 6:22 ` YAMAMOTO Takashi
2008-02-18 6:22 ` YAMAMOTO Takashi
[not found] ` <20080218062209.DA59B1E3C58-Pcsii4f/SVk@public.gmane.org>
2008-02-18 6:20 ` Balbir Singh
2008-02-18 6:20 ` Balbir Singh
[not found] ` <47B923C8.3090904-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-02-18 6:47 ` Li Zefan
2008-02-18 6:47 ` Li Zefan
[not found] ` <47B929EE.7080202-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-02-18 7:01 ` Balbir Singh
2008-02-18 7:01 ` Balbir Singh
2008-02-18 7:14 ` Li Zefan
[not found] ` <47B92D47.2050008-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2008-02-18 7:14 ` Li Zefan
2008-02-18 7:34 ` [PATCH] memcgroup: remove a useless VM_BUG_ON() Li Zefan
2008-02-18 7:34 ` Li Zefan
2008-02-18 8:12 ` Balbir Singh
[not found] ` <47B93518.6-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-02-18 8:12 ` Balbir Singh
2008-02-18 8:48 ` KAMEZAWA Hiroyuki
2008-02-18 8:48 ` KAMEZAWA Hiroyuki
[not found] ` <47B91EC2.3020805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2008-02-18 6:14 ` [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() Balbir Singh
2008-02-18 6:39 ` YAMAMOTO Takashi
2008-02-18 6:39 ` YAMAMOTO Takashi
-- strict thread matches above, loose matches on Subject: below --
2008-02-18 5:59 Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B9223C.9020106@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.