All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] MIPS: Fix CFG_NO_FLASH support
Date: Mon, 18 Feb 2008 23:30:16 +0900	[thread overview]
Message-ID: <47B99678.2070407@ruby.dti.ne.jp> (raw)
In-Reply-To: <1203263884-1282-1-git-send-email-plagnioj@jcrosoft.com>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> @@ -352,13 +355,16 @@ void board_init_r (gd_t *id, ulong dest_addr)
>  	env_name_spec += gd->reloc_off;
>  #endif
>  
> +	bd = gd->bd;
> +
> +#ifndef CFG_NO_FLASH
>  	/* configure available FLASH banks */
>  	size = flash_init();
>  	display_flash_config (size);
> +	bd->bi_flashsize = size;
> +#endif
>  
> -	bd = gd->bd;
>  	bd->bi_flashstart = CFG_FLASH_BASE;
> -	bd->bi_flashsize = size;
>  #if CFG_MONITOR_BASE == CFG_FLASH_BASE
>  	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
>  #else

Hm, could we clean up further more?

diff --git a/lib_mips/board.c b/lib_mips/board.c
index 1645f2c..b9606e4 100644
--- a/lib_mips/board.c
+++ b/lib_mips/board.c
@@ -361,15 +361,15 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	/* configure available FLASH banks */
 	size = flash_init();
 	display_flash_config (size);
+	bd->bi_flashstart = CFG_FLASH_BASE;
 	bd->bi_flashsize = size;
-#endif
 
-	bd->bi_flashstart = CFG_FLASH_BASE;
 #if CFG_MONITOR_BASE == CFG_FLASH_BASE
 	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
 #else
 	bd->bi_flashoffset = 0;
 #endif
+#endif /* CFG_NO_FLASH */
 
 	/* initialize malloc() area */
 	mem_malloc_init();
_

And if possible, please split the patch into two; one is for board.c,
the other for qemu-mips.

  Shinya

  reply	other threads:[~2008-02-18 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 15:58 [U-Boot-Users] [PATCH] MIPS: Fix CFG_NO_FLASH support Jean-Christophe PLAGNIOL-VILLARD
2008-02-18 14:30 ` Shinya Kuribayashi [this message]
2008-02-22 11:09 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47B99678.2070407@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.