From: "David P. Reed" <dpreed@reed.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-kernel] Re: [patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb_p
Date: Mon, 18 Feb 2008 12:30:10 -0500 [thread overview]
Message-ID: <47B9C0A2.2060208@reed.com> (raw)
In-Reply-To: <20080218154546.66e4c72d@core>
Alan Cox wrote:
>> +unsigned char inb_pic(unsigned int port)
>> +{
>> + /* delay for some accesses to PIC on motherboard or in chipset must be
>> + at least one microsecond, but be safe here. */
>> + unsigned char value = inb(port);
>> + udelay(2);
>> + return value;
>> +}
>>
>
> inline it. Its almost no instructions
>
>
Will do. Assume you desire inlining of the outb_pic, and also the
inb_pit and outb_pit routines. Didn't do it because the code is
slightly bigger than the call.
prev parent reply other threads:[~2008-02-18 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 15:06 [patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb_p David P. Reed
2008-02-18 15:45 ` Alan Cox
2008-02-18 17:30 ` David P. Reed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B9C0A2.2060208@reed.com \
--to=dpreed@reed.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.