All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: davem@davemloft.net,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: [NETFILTER 1/3] xt_sctp: simplify xt_sctp.h
Date: Tue, 19 Feb 2008 13:48:01 +0100	[thread overview]
Message-ID: <47BAD001.9050807@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0802061456450.23855@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> commit be0be37421ec037ffcffa9feaf5c561f405ee3dd
> Author: Jan Engelhardt <jengelh@computergmbh.de>
> Date:   Tue Jan 29 16:53:31 2008 +0100
> 
>     [NETFILTER]: xt_sctp: simplify xt_sctp.h
>     
>     The use of xt_sctp.h flagged up -Wshadow warnings in userspace, which
>     prompted me to look at it and clean it up. Basic operations have been
>     directly replaced by library calls (memcpy, memset is both available
>     in the kernel and userspace, and usually faster than a self-made
>     loop). The is_set and is_clear functions now use a processing time
>     shortcut, too.


Please resend this once I open my 2.6.26 tree, we're too late
in 2.6.25 for cleanups.

  reply	other threads:[~2008-02-19 12:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 13:56 [NETFILTER 0/3] Netfilter fixes on top Jan Engelhardt
2008-02-06 13:56 ` [NETFILTER 1/3] xt_sctp: simplify xt_sctp.h Jan Engelhardt
2008-02-19 12:48   ` Patrick McHardy [this message]
2008-02-06 13:57 ` [NETFILTER 2/3] xt_hashlimit: remove unneeded struct member Jan Engelhardt
2008-02-19 12:51   ` Patrick McHardy
2008-02-06 13:57 ` [NETFILTER 3/3] xt_iprange: fix subtraction-based comparison Jan Engelhardt
2008-02-19 12:52   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BAD001.9050807@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.