From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: davem@davemloft.net, netfilter-devel@vger.kernel.org
Subject: Re: [NETFILTER 07/07]: Use __u32 in struct nf_inet_addr
Date: Tue, 19 Feb 2008 18:15:08 +0100 [thread overview]
Message-ID: <47BB0E9C.6060608@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0802191808540.26109@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Feb 19 2008 17:25, Patrick McHardy wrote:
>> [NETFILTER]: Use __u32 in struct nf_inet_addr
>>
>> As reported by David Woodhouse <dwmw2@infradead.org>, using u_int32_t in
>> struct nf_inet_addr breaks the busybox build. Fix by using __u32.
>
> ... that's why I say we should use uint32_t (with just one underscore),
> because that is available in userspace thorugh <stdint.h>,
> while u_int32_t is not (at first glance²).
As David explained, kernel headers shouldn't assume that userspace
has pulled in any of these typedefs and therefore should use
the kernel-internally defined types.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-02-19 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 16:25 [NETFILTER 00/07]: Netfilter fixes Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 01/07]: nfnetlink_queue: fix SKB_LINEAR_ASSERT when mangling packet data Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 02/07]: xt_u32: drop the actually unused variable from u32_match_it Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 03/07]: Fix incorrect use of skb_make_writable Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 04/07]: Make sure xt_policy.h is unifdef'ed Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 05/07]: xt_hashlimit: remove unneeded struct member Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 06/07]: xt_iprange: fix subtraction-based comparison Patrick McHardy
2008-02-19 16:25 ` [NETFILTER 07/07]: Use __u32 in struct nf_inet_addr Patrick McHardy
2008-02-19 17:11 ` Jan Engelhardt
2008-02-19 17:15 ` Patrick McHardy [this message]
2008-02-20 1:25 ` [NETFILTER 00/07]: Netfilter fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BB0E9C.6060608@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.