From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Date: Tue, 19 Feb 2008 21:49:33 +0000 Subject: [PATCH] uml: use DIV_ROUND_UP Message-Id: <47BB4EED.7020109@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Hi, I just saw similar patches in the janitor kernel's list, and spotted place it fits. Signed-off-by: Jiri Olsa --- arch/um/drivers/ubd_kern.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index b1a77b1..1e579e4 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c @@ -1020,8 +1020,7 @@ static void cowify_bitmap(__u64 io_offset, int length, unsigned long *cow_mask, * by one word. Thanks to Lynn Kerby for the fix and James McMechan * for the original diagnosis. */ - if(*cow_offset = ((bitmap_len + sizeof(unsigned long) - 1) / - sizeof(unsigned long) - 1)) + if(*cow_offset = (DIV_ROUND_UP(bitmap_len, sizeof(unsigned long)) - 1)) (*cow_offset)--; bitmap_words[0] = bitmap[*cow_offset]; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JRaLL-0003Ej-JE for user-mode-linux-devel@lists.sourceforge.net; Tue, 19 Feb 2008 13:49:39 -0800 Received: from ug-out-1314.google.com ([66.249.92.171]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JRaLJ-0002Ga-L5 for user-mode-linux-devel@lists.sourceforge.net; Tue, 19 Feb 2008 13:49:39 -0800 Received: by ug-out-1314.google.com with SMTP id m2so632795uge.28 for ; Tue, 19 Feb 2008 13:49:36 -0800 (PST) Message-ID: <47BB4EED.7020109@gmail.com> Date: Tue, 19 Feb 2008 22:49:33 +0100 From: Jiri Olsa MIME-Version: 1.0 Subject: [uml-devel] [PATCH] uml: use DIV_ROUND_UP List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Jeff Dike , kernel-janitors@vger.kernel.org Cc: uml-devel Hi, I just saw similar patches in the janitor kernel's list, and spotted place it fits. Signed-off-by: Jiri Olsa --- arch/um/drivers/ubd_kern.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index b1a77b1..1e579e4 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c @@ -1020,8 +1020,7 @@ static void cowify_bitmap(__u64 io_offset, int length, unsigned long *cow_mask, * by one word. Thanks to Lynn Kerby for the fix and James McMechan * for the original diagnosis. */ - if(*cow_offset == ((bitmap_len + sizeof(unsigned long) - 1) / - sizeof(unsigned long) - 1)) + if(*cow_offset == (DIV_ROUND_UP(bitmap_len, sizeof(unsigned long)) - 1)) (*cow_offset)--; bitmap_words[0] = bitmap[*cow_offset]; ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel