From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, Updated] remove shouting-indirection macros from xfs_sb.h
Date: Tue, 19 Feb 2008 18:44:58 -0600 [thread overview]
Message-ID: <47BB780A.5090705@sandeen.net> (raw)
In-Reply-To: <47AE0419.6050000@sandeen.net>
Eric Sandeen wrote:
> (missed one instance of XFS_SB_VERSION_HASLOGV2)
>
> Remove macro-to-small-function indirection from xfs_sb.h,
> and remove some which are completely unused.
>
> Some day I'll get them all...
Christoph likes it. does sgi?
Thanks,
-Eric
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>
> ---
>
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ioctl.c
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
> @@ -1052,7 +1052,7 @@ xfs_ioctl(
> * Only allow the sys admin to reserve space unless
> * unwritten extents are enabled.
> */
> - if (!XFS_SB_VERSION_HASEXTFLGBIT(&mp->m_sb) &&
> + if (!xfs_sb_version_hasextflgbit(&mp->m_sb) &&
> !capable(CAP_SYS_ADMIN))
> return -EPERM;
>
next prev parent reply other threads:[~2008-02-20 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 6:14 [PATCH] remove shouting-indirection macros from xfs_sb.h Eric Sandeen
2008-02-09 6:33 ` Christoph Hellwig
2008-02-09 19:50 ` [PATCH, Updated] " Eric Sandeen
2008-02-20 0:44 ` Eric Sandeen [this message]
2008-02-20 4:42 ` Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BB780A.5090705@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.